Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like a way to not log as error stuff that isn't an actual error #194

Closed
Yoric opened this issue Jan 13, 2022 · 0 comments
Closed

I'd like a way to not log as error stuff that isn't an actual error #194

Yoric opened this issue Jan 13, 2022 · 0 comments

Comments

@Yoric
Copy link

Yoric commented Jan 13, 2022

For instance, in the CI logs of Mjölnir, we have dozens of

Thu, 13 Jan 2022 10:45:32 GMT [ERROR] [MatrixHttpClient (REQ-264)] Error: Error during MatrixClient request GET /_matrix/client/r0/rooms/!nyFIVcdXpHcpRNRBFk%3Alocalhost%3A9999/state/m.room.canonical_alias/: 404 Not Found -- {"errcode":"M_NOT_FOUND","error":"Event not found."}
    at /home/yoric/Documents/Code/mjolnir/src/utils.ts:231:21
    at result (/home/yoric/Documents/Code/mjolnir/src/utils.ts:338:21)
    at new Promise (<anonymous>)
    at /home/yoric/Documents/Code/mjolnir/src/utils.ts:337:43
    at Generator.next (<anonymous>)
    at /home/yoric/Documents/Code/mjolnir/src/utils.ts:23:71
    at new Promise (<anonymous>)
    at __awaiter (/home/yoric/Documents/Code/mjolnir/src/utils.ts:19:12)
    at /home/yoric/Documents/Code/mjolnir/src/utils.ts:333:39
    at /home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/http.js:63:33
    at new Promise (<anonymous>)
    at Object.doHttpRequest (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/http.js:62:12)
    at MatrixClient.doRequest (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/MatrixClient.js:1493:23)
    at MatrixClient.descriptor.value (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/metrics/decorators.js:22:41)
    at MatrixClient.getRoomStateEvent (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/MatrixClient.js:737:21)
    at MatrixClient.descriptor.value (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/metrics/decorators.js:22:41)
    at MatrixClient.<anonymous> (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/MatrixClient.js:335:42)
    at Generator.next (<anonymous>)
    at fulfilled (/home/yoric/Documents/Code/mjolnir/node_modules/matrix-bot-sdk/lib/MatrixClient.js:14:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

(we have a custom requestFn that cleans up error logs - otherwise, it's 800loc and no stack)

All of them caused by innocuous calls to getPublishedAlias.

@Yoric Yoric closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant