Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chinese support for localpart #60

Open
LaysDragon opened this issue Sep 3, 2019 · 1 comment
Open

add chinese support for localpart #60

LaysDragon opened this issue Sep 3, 2019 · 1 comment

Comments

@LaysDragon
Copy link

LaysDragon commented Sep 3, 2019

Bot generate part of ulocalpart via display name..
But it will lead to some problem if display name container some non-English character some thing like

  • github 通知 => github___
  • github 大小 => github___
    Those different display name webhook will share same localpart because of failed generated of specified character
    there is a library can use to solve this problem like this one
    https://www.npmjs.com/package/limax
@LaysDragon
Copy link
Author

https://github.com/LaysDragon/matrix-appservice-webhooks/tree/chinese_support
here is my implenment...It will caused duplicate bot appear due to fixed localpart if there is any webhook have been deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant