Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owner to okta_group table #132

Open
securitygeneration opened this issue Jul 12, 2024 · 9 comments
Open

Add owner to okta_group table #132

securitygeneration opened this issue Jul 12, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request new table New table request stale No recent activity has been detected on this issue/PR and it will be closed

Comments

@securitygeneration
Copy link

References
https://developer.okta.com/docs/api/openapi/okta-management/management/tag/GroupOwner/

@securitygeneration securitygeneration added enhancement New feature or request new table New table request labels Jul 12, 2024
@ParthaI ParthaI self-assigned this Jul 15, 2024
ParthaI added a commit that referenced this issue Jul 15, 2024
@ParthaI
Copy link
Contributor

ParthaI commented Jul 15, 2024

Hello @securitygeneration, just a heads-up: we've added support for a new table named okta_group_owner in this PR. This table will list all the owners of groups.

I couldn't test it in my environment due to a lack of permissions.

It would be great if you could try it out from the PR branch issue-132.

Steps to build the plugin locally from the branch issue-132

Thanks

@securitygeneration
Copy link
Author

Hi @ParthaI, thanks!

Getting this error:

> select * from okta_group_owner

Error: okta: parsing time "2023-09-26 12:18:57.0" as "2006-01-02T15:04:05Z07:00": cannot parse " 12:18:57.0" as "T" (SQLSTATE HV000)

@ParthaI
Copy link
Contributor

ParthaI commented Jul 15, 2024

Hello @securitygeneration,

Thank you so much for testing the PR. I have addressed the above error and pushed a fix in the same branch (issue-132). Could you please pull the latest changes from the branch and try running the query by building the plugin locally again?

@securitygeneration
Copy link
Author

Still getting this error after doing a git pull and make:

Error: okta: parsing time "2023-09-26 12:21:00.0" as "2006-01-02T15:04:05Z07:00": cannot parse " 12:21:00.0" as "T" (SQLSTATE HV000)

@ParthaI
Copy link
Contributor

ParthaI commented Jul 15, 2024

Could you please confirm if you have terminated all running Steampipe processes before building the plugin again? If not, please run the command pkill "steampipe" before building/querying the plugin.

@securitygeneration
Copy link
Author

Still the same error

@ParthaI
Copy link
Contributor

ParthaI commented Jul 17, 2024

Hi @securitygeneration,

I apologize for the inconvenience. I have pushed some fixes to the issue-132 branch to address the timestamp parsing issue.

Could you please pull the latest changes from the issue-132 branch, rebuild the plugin locally, and run the query again? If possible, could you also share your log details from ~/.steampipe/logs/plugin-...., making sure to remove any sensitive information?

Thank you!

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Sep 15, 2024
@ParthaI ParthaI removed the stale No recent activity has been detected on this issue/PR and it will be closed label Sep 16, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new table New table request stale No recent activity has been detected on this issue/PR and it will be closed
Projects
None yet
Development

No branches or pull requests

2 participants