Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests wait indefinitely (no timeout) #82

Open
AlmightyOatmeal opened this issue Apr 12, 2016 · 2 comments
Open

Requests wait indefinitely (no timeout) #82

AlmightyOatmeal opened this issue Apr 12, 2016 · 2 comments

Comments

@AlmightyOatmeal
Copy link

While iterating through posts, occasionally it will just sit... and sit... and sit... and sit...

By default, the httplib module that the oauth2 module uses has no timeout which means it will sit indefinitely. I'm not sure why nobody thought of this yet but why isn't there a default timeout set? I did it by creating a simple decorator and applying it to TumblrRequest().get().

Before signing my life away (CLA) and contributing my code, I thought I would bring this topic up and see if someone has already worked on this idea.

@xavyjs
Copy link

xavyjs commented Dec 7, 2016

@AlmightyOatmeal I have experienced the same issue when fetching more posts. Pls. share your solution if it is thread safe.

@jasonpenny
Copy link
Contributor

Do you know if this is still an issue now that this module uses requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants