Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding source_url to a new post #145

Open
alglez opened this issue May 5, 2021 · 2 comments · May be fixed by #146
Open

Adding source_url to a new post #145

alglez opened this issue May 5, 2021 · 2 comments · May be fixed by #146

Comments

@alglez
Copy link

alglez commented May 5, 2021

Checking the tumblr API I don´t think there is not a request parameter to add a source_url for the content.

For example creating a photo. The source parameter refers to the source for the picture, but the source_url or "content source" is actually the original source for the content. Which is explained here:

https://support.tumblr.com/post/125279368827/heres-a-nice-thing-no-matter-how-many-times-an

It will be nice to be able to add that directly from the API when creating a new post.

@mdawaffe
Copy link

mdawaffe commented May 6, 2021

Though not well documented, the HTTP API does accept a source_url string parameter for this, but (as you know) the python library does not. I think getting this working would only require adding 'source_url' to the list of post parameters at:

valid = ['type', 'state', 'tags', 'tweet', 'date', 'format', 'slug']

Are you interested in writing a PR?

@alglez
Copy link
Author

alglez commented May 8, 2021

I reread the HTTP API because I thought it was missing as well there (post vs posts neue post format), but yes you are right, I can write and test that PR. Probably during next week.

@alglez alglez linked a pull request May 10, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants