Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kanvas update with 9:16 export fixes #16583

Closed
wants to merge 1 commit into from
Closed

Kanvas update with 9:16 export fixes #16583

wants to merge 1 commit into from

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented May 27, 2021 •
edited
Loading

Fixes tumblr/kanvas-ios#62

Related PRs

tumblr/kanvas-ios#114

Testing

  • Create a Story post
  • Add landscape and portrait media
  • Add text to the media
  • Ensure that the media posted uploaded to the site is roughly 9:16. (about 0.5625 when dividing the width by the height)
  • Ensure text is positioned as expected

Regression Notes

  1. Potential unintended areas of impact

Anything related to Story media export.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Tested posting stories with a variety of media sizes and types.

  1. What automated tests I added (or what prevented me from doing so)

Unfortunately, the OpenGL rendering will not work in the simulator so we cannot test this.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@bjtitus bjtitus added this to the 17.5 milestone May 27, 2021
@bjtitus bjtitus self-assigned this May 27, 2021
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 27, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@bjtitus bjtitus mentioned this pull request May 27, 2021
Open
@jkmassel
Copy link
Contributor

We're cutting 17.5 today, so this PR is being bumped to 17.6

@jkmassel jkmassel modified the milestones: 17.5, 17.6 May 31, 2021
@mokagio mokagio modified the milestones: 17.6, 17.7 Jun 14, 2021
@mokagio
Copy link
Contributor

mokagio commented Jun 14, 2021

Bumping this to 17.7 as part of the open PRs walkthrough before starting the 17.6 code freeze because it's still a draft.

Thank you for working on this 🙇

@mokagio
Copy link
Contributor

mokagio commented Jun 28, 2021

@bjtitus I'm going to bump this to the next release because we'll be code freezing 17.7 today and this is still a draft.

If this cannot wait two weeks and it's important that this makes it into this release, let me know and we'll organize a new beta once ready. 👍

Also, both this and #16031 have been sitting here for a while. Is there something I can do to help unstuck them? 🤔

@mokagio mokagio modified the milestones: 17.7, 17.8 Jun 28, 2021
@mokagio mokagio mentioned this pull request Jun 28, 2021
Closed
3 tasks
@mokagio
Copy link
Contributor

mokagio commented Jul 12, 2021

Pushing this PR to the next milestone, 17.9, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 17.8, 17.9 Jul 12, 2021
@mokagio
Copy link
Contributor

mokagio commented Jul 26, 2021

Pushing this PR to the next milestone, 18.0, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 17.9, 18.0 Jul 26, 2021
@mokagio
Copy link
Contributor

mokagio commented Aug 9, 2021

Pushing this PR to the next milestone, 18.1, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 18.0, 18.1 Aug 9, 2021
@mokagio
Copy link
Contributor

mokagio commented Aug 23, 2021

Pushing this PR to the next milestone, 18.2, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio removed this from the 18.1 milestone Aug 23, 2021
@mokagio mokagio added this to the 18.2 milestone Aug 23, 2021
@mokagio
Copy link
Contributor

mokagio commented Sep 6, 2021 •
edited
Loading

Pushing this PR to the next milestone, 18.3, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 18.2, 18.3 Sep 6, 2021
@mokagio
Copy link
Contributor

mokagio commented Sep 20, 2021

Pushing this PR to the next milestone, 18.4, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 18.3, 18.4 Sep 20, 2021
@mokagio
Copy link
Contributor

mokagio commented Oct 4, 2021

Pushing this PR to the next milestone, 18.5, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 18.4, 18.5 Oct 4, 2021
@mokagio
Copy link
Contributor

mokagio commented Oct 17, 2021

Pushing this PR to the next milestone, 18.6, because I'm running the code-freeze today and this is still a draft.

@mokagio mokagio modified the milestones: 18.5, 18.6 Oct 17, 2021
@oguzkocer oguzkocer removed this from the 18.6 milestone Nov 1, 2021
@twstokes
Copy link
Contributor

👋 I'm going to close this PR due to lack of activity, but please reopen if this was an error. Thank you.

@twstokes twstokes closed this Aug 25, 2023
@jkmassel jkmassel deleted the fix/stories-9-16-export branch July 26, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjtitus bjtitus

Labels
[Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text isn't positioned properly in export images
5 participants
@bjtitus @jkmassel @mokagio @twstokes @oguzkocer