Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add ExecAction to config(map) #35

Open
kgunjikar opened this issue Nov 4, 2019 · 0 comments
Open

Feature Request: Add ExecAction to config(map) #35

kgunjikar opened this issue Nov 4, 2019 · 0 comments

Comments

@kgunjikar
Copy link

As a part of injection for sidecars I want to be able to call a preStop hook , so we can cleanup before exit.

ConfigMap Change.

imagePullPolicy: IfNotPresent
lifecycle:
preStop:
exec: ["/bin/bash", "-c", "/opt/bin/prestop"]

E1104 19:09:48.504599 1 main.go:132] error reconciling configmaps: error getting ConfigMaps from API: error parsing ConfigMap sidecar-test item test1 into injection config: e rror unmarshaling JSON: json: cannot unmarshal array into Go struct field Handler.exec of type v1.ExecAction

I guess we will have to add to InjectionConfig structure

Version Deets

  • Kubernetes Version: 1.15.3
  • k8s-sidecar-injector Version: Top of Tree.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant