Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase version 7.13.3 fails to build with Tuist projects #6284

Closed
shahzadmajeed opened this issue May 14, 2024 · 1 comment
Closed

Firebase version 7.13.3 fails to build with Tuist projects #6284

shahzadmajeed opened this issue May 14, 2024 · 1 comment
Labels
type:bug Something isn't working

Comments

@shahzadmajeed
Copy link
Collaborator

What happened?

As mentioned in this firebase thread firebase/firebase-ios-sdk#12949, Tuist users are facing a build issue with their latest version 7.13.3 which doesn't happen in 7.13.2

I will provide a reproducible project but it might just be a matter of updating dependency version to latest in https://github.com/tuist/tuist/tree/main/fixtures/multiplatform_app_with_sdk fixture.

Slack thread is here https://tuist-community.slack.com/archives/C018QG7U7SN/p1715691408936109

How do we reproduce it?

Update firebase dependency to 7.13.3 and build project you will see firebase/firebase-ios-sdk#12949 issue

Error log

/xxx/project-name/Tuist/Dependencies/SwiftPackageManager/.build/checkouts/firebase-ios-sdk/FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift:176:16: error: type 'NSData' has no member 'gul_data'
try NSData.gul_data(byGzippingData: self)
~~~~~~ ^~~~~~~~
/xxx/project-name/Tuist/Dependencies/SwiftPackageManager/.build/checkouts/firebase-ios-sdk/FirebaseCore/Internal/Sources/HeartbeatLogging/HeartbeatsPayload.swift:183:16: error: type 'NSData' has no member 'gul_data'
try NSData.gul_data(byInflatingGzippedData: self)

macOS version

14

Tuist version

3.42.3

Xcode version

15.2

@shahzadmajeed shahzadmajeed added the type:bug Something isn't working label May 14, 2024
@fortmarek
Copy link
Member

As confirmed by @ajkolean here, Tuist 4 integration works well. We no longer support Tuist 3 and don't plan to backport any fixes to it. There has been a lot of work done to improve the integration of SPM dependencies in the latest version that's hard to backport.

Most of the work was around modulemaps and header search paths, but it's hard to say what exactly is missing in this instance.

We recommend migrating to Tuist 4 or using the vanilla SPM integration instead of the XcodeProj-based one (using .package instead of .external)

usa4060 added a commit to depromeet/WalWal-iOS that referenced this issue Aug 7, 2024
*[Tuist 정적 링크 관련 이슈]*
tuist/tuist#6284
firebase/firebase-ios-sdk#12949

추후 Tuist 4.0 마이그레이션 필요성 있음....

현재 상황 -> Firebase에서 Taeget으로 사용 중인 Google Utilities의 Privacy Manifest가 Google Utilities 7.13.3에서 릴리즈 되었는데, 현재 사용중인 Tuist 3.x에서는 정적�링크 불가능함,,,(3.x에 대해선 추가 지원 안한다고 함)

따라서, Firebase SDK에 대해서 Tuist의 XcodeProj-based 빌드 대신 바닐라 SPM방식으로 처리
usa4060 added a commit to depromeet/WalWal-iOS that referenced this issue Aug 7, 2024
* feat: #89 FCM에 사용 할 Google-Info 환경 분리를 위한 resources 경로 변경

* chore: develop 코드 싱크

* feat: #90 FirebaseMesseging 의존성 추가.

*[Tuist 정적 링크 관련 이슈]*
tuist/tuist#6284
firebase/firebase-ios-sdk#12949

추후 Tuist 4.0 마이그레이션 필요성 있음....

현재 상황 -> Firebase에서 Taeget으로 사용 중인 Google Utilities의 Privacy Manifest가 Google Utilities 7.13.3에서 릴리즈 되었는데, 현재 사용중인 Tuist 3.x에서는 정적�링크 불가능함,,,(3.x에 대해선 추가 지원 안한다고 함)

따라서, Firebase SDK에 대해서 Tuist의 XcodeProj-based 빌드 대신 바닐라 SPM방식으로 처리

* fix: #90 tuist resolved 제거 .gitignore 추가

* fix: AppDelegate 내부 로직 분리

* feat: #90 FCM 원격 등록 및 배너 action 처리로직 추가 + deepLink 초기 세팅

* fix: #90 FCM 관련 코드 정리

* feat: #90 FCM Local 저장
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants