More work on Finder tagging

Click the preferences warning, click thru the warning and ALL FINDER
TAGS and ALL OM TAGS get merged and from then on, no way to go back,
nvALT will use Finder tagging.

For debugging purposes, check in AppController.h, set
k_FinderTaggingReset to 1   to have your preference for
useFinderTagging removed on launch. Quit, and set k_FinderTaggingReset
back to 0,  before doing anything.

Author: elasticthreads

AppController.h

@@ -148,8 +148,6 @@ void outletObjectAwoke(id sender);
 - (IBAction)importNotes:(id)sender;
 - (IBAction)switchViewLayout:(id)sender;
 
-- (IBAction)mirrorAllOMToFinder:(id)sender;
-
 - (IBAction)fieldAction:(id)sender;
 - (NoteObject*)createNoteIfNecessary;
 - (void)searchForString:(NSString*)string;

AppController.m

@@ -70,6 +70,7 @@
 //#define kDefaultMarkupPreviewMode @"markupPreviewMode"
 #define kDualFieldHeight 35.0
 
+#define k_FinderTaggingReset 1
 
 NSWindow *normalWindow;
 NSInteger ModFlagger;
@@ -94,6 +95,11 @@ + (void)initialize
 - (id)init {
     self = [super init];
     if (self) {
+        
+#if k_FinderTaggingReset
+        [[NSUserDefaults standardUserDefaults]removeObjectForKey:@"UseFinderTags"];
+#endif
+        
         hasLaunched=NO;
 
         if (![[NSUserDefaults standardUserDefaults] boolForKey:@"ShowDockIcon"]){
@@ -123,7 +129,7 @@ - (id)init {
         NSFileManager *fileManager = [NSFileManager defaultManager];
 
 
-        NSString *folder = [[NSFileManager defaultManager] applicationSupportDirectory];
+        NSString *folder = [fileManager applicationSupportDirectory];
 
         if ([fileManager fileExistsAtPath: folder] == NO)
         {
@@ -537,6 +543,7 @@ - (void)applicationDidFinishLaunching:(NSNotification*)aNote {
 	 @selector(removeTableColumn:sender:),  //ditto
 	 @selector(setTableColumnsShowPreview:sender:),  //when to tell notationcontroller to generate or disable note-body previews
 	 @selector(setConfirmNoteDeletion:sender:),  //whether "delete note" should have an ellipsis
+     @selector(setUseFinderTags:),  //whether nvalt should use findertags
 	 @selector(setAutoCompleteSearches:sender:),@selector(setUseETScrollbarsOnLion:sender:), nil];   //when to tell notationcontroller to build its title-prefix connections
 
 	[self performSelector:@selector(runDelayedUIActionsAfterLaunch) withObject:nil afterDelay:0.0];
@@ -1113,7 +1120,9 @@ - (void)settingChangedForSelectorString:(NSString*)selectorString {
 		if ([prefsController autoCompleteSearches])
 			[notationController updateTitlePrefixConnections];
 
-	}
+	}else if ([selectorString isEqualToString:SEL_STR(setUseFinderTags:)]) {
+        [notationController mirrorAllOMToFinderTags];
+    }
 
 }
 
@@ -1877,10 +1886,6 @@ - (NoteObject*)createNoteIfNecessary {
     return currentNote;
 }
 
-- (IBAction)mirrorAllOMToFinder:(id)sender
-{
-	[notationController mirrorAllOMToFinderTags];
-}
 
 - (void)restoreListStateUsingPreferences {
 	//to be invoked after loading a notationcontroller

English.lproj/NotationPrefsView.nib/designable.nib

@@ -147,7 +147,8 @@ BOOL ColorsEqualWith8BitChannels(NSColor *c1, NSColor *c2);
 - (void)setSoftTabs:(BOOL)value sender:(id)sender;
 - (BOOL)softTabs;
 
-- (void)setUseFinderTags:(BOOL)value sender:(id)sender;
+- (void)setUseFinderTags:(id)sender;
+//- (void)setUseFinderTags:(BOOL)value sender:(id)sender;
 - (BOOL)useFinderTags;
 
 - (NSInteger)numberOfSpacesInTab;

English.lproj/NotationPrefsView.nib/keyedobjects.nib

@@ -115,7 +115,7 @@ static void sendCallbacksForGlobalPrefs(GlobalPrefs* self, SEL selector, id orig
 
 - (id)init {
 	if (self=[super init]) {
-	
+        
 		runCallbacksIMP = [self methodForSelector:@selector(notifyCallbacksForSelector:excludingSender:)];
 		selectorObservers = [[NSMutableDictionary alloc] init];
 
@@ -124,7 +124,7 @@ - (id)init {
 		tableColumns = nil;
 
 		[defaults registerDefaults:[NSDictionary dictionaryWithObjectsAndKeys:
-			[NSNumber numberWithBool:IsMavericksOrLater], UseFinderTagsKey,
+			[NSNumber numberWithBool:NO], UseFinderTagsKey,
 			[NSNumber numberWithBool:YES], AutoSuggestLinksKey,
 			[NSNumber numberWithBool:YES], AutoFormatsDoneTagKey, 
 			[NSNumber numberWithBool:YES], AutoIndentsNewLinesKey, 
@@ -539,16 +539,20 @@ - (NSDictionary*)searchTermHighlightAttributes {
 
 }
 
-- (void)setUseFinderTags:(BOOL)value sender:(id)sender {
+- (void)setUseFinderTags:(id)sender {
 	if (!IsMavericksOrLater) {
 		[defaults setBool:NO forKey:UseFinderTagsKey];
 		return;
 	}
-	[defaults setBool:value forKey:UseFinderTagsKey];
+	[defaults setBool:YES forKey:UseFinderTagsKey];
+	SEND_CALLBACKS();
 }
 
 - (BOOL)useFinderTags
 {
+    if (!IsMavericksOrLater) {
+        return NO;
+    }
 	return [defaults boolForKey:UseFinderTagsKey];
 }
 

GlobalPrefs.h

@@ -36,7 +36,7 @@
 - (BOOL)createFolderAtPath:(NSString *)path withAttributes:(NSDictionary *)attributes;
 - (NSDictionary *)attributesAtPath:(NSString *)path followLink:(BOOL)follow;
 - (NSArray *)folderContentsAtPath:(NSString *)path;
-- (BOOL)mirrorOMToFinderTags:(const char*)path;
+- (NSArray *)mergedTagsForFileAtPath:(const char*)path;
 - (BOOL)deleteFileAtPath:(NSString *)path;
 
 @end