Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caching access tokens #15

Open
dedomil opened this issue Oct 4, 2023 · 3 comments
Open

caching access tokens #15

dedomil opened this issue Oct 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@dedomil
Copy link

dedomil commented Oct 4, 2023

the access token have a lifetime of 3600s, so why not cache them rather than creating new access tokens at every request?

@tthn0
Copy link
Owner

tthn0 commented Oct 4, 2023

The original project that I took inspiration from didn't have a caching mechanism, and I never thought to create one. That's actually a very good idea to implement. However, this project isn't my priority at the moment, so I won't be updating it to include a form of caching any time soon. Feel free to submit a pull request, and thanks for the suggestion!

@tthn0 tthn0 added the enhancement New feature or request label Oct 4, 2023
@dedomil
Copy link
Author

dedomil commented Oct 4, 2023

okay, I could have submitted a PR but I am pretty noob at python, also I am creating same thing on node.js but the problem is I am struggling in making a svg (never made before), so can you give me an idea how to make a svg? can I take your template for my project?

@tthn0
Copy link
Owner

tthn0 commented Oct 11, 2023

Sorry for the delayed response, I have been busy and will review the PR whenever I have time. Yes, you may refer to my template for your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants