Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] parse lat/long fields with more than one typo #366

Open
NickKauf opened this issue Mar 18, 2023 · 4 comments
Open

[FEATURE] parse lat/long fields with more than one typo #366

NickKauf opened this issue Mar 18, 2023 · 4 comments
Assignees
Labels
feature A new feature that needs adding frontend Mostly frontend work

Comments

@NickKauf
Copy link

NOTE: consider posting this feature request as a Discussion instead of an Issue

Is your feature request related to a problem? Please describe.
trying to visualize this data set on a map, but the lat long is nested within parentheses i.e "POLYGON(lat, long)"

https://data.cityofnewyork.us/Recreation/NYC-Parks-Pools/y5rm-wagw)

Describe the solution you'd like
so I'd like to be able to parse it out to view on the map

Describe alternatives you've considered
manually parsing or writing a rule to pull out the lat long

Additional context
image

@NickKauf NickKauf added the feature A new feature that needs adding label Mar 18, 2023
@jps327
Copy link
Contributor

jps327 commented Mar 18, 2023

This is a great idea and one we should definitely prioritize on our end. Thanks for the heads up! We'll add some more ways to parse lat/long coordinates to improve the automatic detection but will also add some UI options for you to manually specify which are the lat/long columns. I'll update this issue once we kick off work on this and push the updates

@jps327
Copy link
Contributor

jps327 commented Mar 18, 2023

I do want to clarify though that this wouldn't solve the exact issue you're facing with this particular dataset.
This dataset (NYC-Parks-Pools) doesn't have any lat/long column at all. The column in your screenshot is actually a polygon, i.e. each row is actually a list of lat/longs:

Screenshot 2023-03-18 at 2 55 33 PM

So each row is actually not a "point", each row is a region (i.e. a "polygon" - each row actually contains the points that map the entire perimeter of each pool).

We could consider adding a toggle to the map to change the feature rendering from points to polygons, and then you can specify which column contains the list of coordinates for each polygon. However this will take a longer to build though because this feature was built with points in mind, not polygons!

@hydrosquall
Copy link
Contributor

In this case, each of the polygons is quite small (it's the shape of a pool), which when viewed from sufficient distance, might render the polygon too small to actually see (e.g. if you're at a level where you can actually see the shape of a borough). I suspect most of these pools will just look like dots once you're zoomed out.

In advance of offering polygon rendering support, perhaps it could simplify to offer the ability to reduce a polygon to a point (by finding its center ), and graphing the center points instead.

@jps327
Copy link
Contributor

jps327 commented Mar 30, 2023

@NickKauf just wanted to give an update that we've started work on this. We should have some more updates next week and hopefully push those changes to production

@jps327 jps327 self-assigned this Mar 30, 2023
@jps327 jps327 added the frontend Mostly frontend work label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature that needs adding frontend Mostly frontend work
Projects
None yet
Development

No branches or pull requests

3 participants