-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Define ESLint library type boundary constraints #46
Comments
@labeled Thank you so much for the suggestion. I am aware of this, and as mentioned on the README, this is my first Nx project, so I want to get something out quickly. That's why I took some shortcuts to reuse the UI component in the same places and plug them directly into the data access. That said, It would come in a few weeks. If you feel like you want to create a PR in the meantime, feel free. Thanks again :) |
The project doesn't have ESLint Boundary setup but most, if not all, libs already have tags defined so applying the boundary should be fairly straight-forward |
Please review my PR #77 |
Thanks @leonlafa, I am looking into it 😁 |
While this does use NX it does not seem to define the boundary constraints between library types. Many ui libraries are depending on data-access libraries and are outside of the scope nx suggests in their documentation that can be found here.
Updating the "depConstraints" to match the suggested dependency constraints will cause eslint to fail.
Dependency Constraints
Feature Library -> can depend on any type of library.
UI Library -> can only depend on other ui or util libraries.
Data-access library -> can only depend on data-access and util libraries.
Utility library -> can only depend on utility libraries.
The text was updated successfully, but these errors were encountered: