Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Load the liked songs Async and cache in Local Storage #33

Open
wellington1993 opened this issue Apr 5, 2021 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@wellington1993
Copy link

HI,

Nice work. I have an suggestion:
Load the liked songs in the background(Service worker?) and save the list in the Local Storage.

I have 10k liked song and the browser crash when I try to load the liked song list.
Maybe an live stream teaching that?

Thanks!

@trungvose
Copy link
Owner

trungvose commented Apr 6, 2021

@wellington1993 Thanks for the suggestion. I haven't added the liked song list yet. So I am not sure when you mentioned browser crash. Was you use the 'real' Spotify app itself?
Because technically I think they won't give me a list of 10000 songs in one go, It will be paginated so that we don't have to worry about this problem :)

@trungvose trungvose added the help wanted Extra attention is needed label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants