Branding Page #1058
Branding Page #1058
Conversation
|
Hello, @kevinbluer and @davidmurdoch I have completed the UI for mentioned issue #944 please review and requesting for little help regarding content and others design changes if required. also thank you so much for assigning the issue, it was a great learning experience let me know if I can help with any changes if required. |
|
Thanks @howdyAnkit! We'll take a look soon! |
There was a problem hiding this comment.
Thanks for this @howdyAnkit. we have to review the rest of this but wanted to ask about the win-node-env module.
package.json
Outdated
| @@ -39,6 +39,7 @@ | |||
| "@trufflesuite/metalsmith-markdown-precompiler": "^1.0.1", | |||
| "handlebars-helpers": "^0.10.0", | |||
| "metalsmith-debug": "^1.2.0", | |||
| "metalsmith-env": "^2.1.2" | |||
| "metalsmith-env": "^2.1.2", | |||
| "win-node-env": "^0.4.0" | |||
There was a problem hiding this comment.
What's win-node-env used for? I don't think it will work on linux.
There was a problem hiding this comment.
not sure Why I did that. must be having some trouble setting the dev env. should I remove that and push the change? I guess it was a bad practice for pushing the node modules folder/editing package.json will keep this in mind going ahead.
There was a problem hiding this comment.
Thanks. If it isn't necessary it should be removed.
|
Hey, @MicaiahReid @CombsieZ @cds-amal any update on this PR? |
|
Sorry for the delay @howdyAnkit , I've asked another team member to review. |
|
@howdyAnkit |
commits regarding issue #944
Please don't review it yet there are some changes still remaining.