Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed update to github action #2622

Open
jingles opened this issue Mar 25, 2024 · 2 comments
Open

Proposed update to github action #2622

jingles opened this issue Mar 25, 2024 · 2 comments

Comments

@jingles
Copy link

jingles commented Mar 25, 2024

Description

If the trufflehog action.yml had an output status, the user could programmatically determine whether the job exited due to a secret detection or some other problem. This can be helpful to prevent false alerting when (for example) the trufflehog docker image is temporarily unavailable and we exit with some status other than 183.

Preferred Solution

I've already done a simple version of this on my own and intend to submit a PR. basically, just use trap combined with an output variable.

Additional Context

Anyone else think this would be handy? I'll likely submit the PR either way 🤷‍♂️...thanks for reading!

@jingles
Copy link
Author

jingles commented Mar 26, 2024

I have a branch ready to go, but don't have access to push... how do I go about this? I signed the CLA... thanks

@jingles
Copy link
Author

jingles commented Mar 26, 2024

@skeweredlogic noticed you were active on the actions side of things, would appreciate your thoughts. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant