Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Immich] Disable database initialization #21749

Open
2 tasks done
MistarMuffin opened this issue May 7, 2024 · 4 comments
Open
2 tasks done

[Immich] Disable database initialization #21749

MistarMuffin opened this issue May 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@MistarMuffin
Copy link

Is your feature request related to a problem?

I've been working to find a reliable and clean disaster-recovery procedure for immich on TrueCharts. Restoring Heavyscript db dumps with pgadmin or other tools don't work perfectly due to database conflicts stemming from db activitythat happens when the app first spins up. To help with this, the immich devs have added a new environmental variable that skips the db initialization which should allow for a clean database for restorations:

immich-app/immich#9069

This variable needs to be visible to the main immich-server and immich-microservices containers. I added the variable in the Scale UI under Extra Environmental Variables but printenv does not show the variable in these containers.

Describe the solution you'd like

A GUI checkbox to enable this flag would be great. Otherwise just having the Extra Environmental Variables get passed into the two mentioned containers should also work.

Describe alternatives you've considered

I have tried restoring an immich database dump numerous other ways and none of them are error free or fully clean. This flag was created by the immich devs to aid in restorations on platforms where it's difficult or impossible to start the database instance without also starting the server and microservices which alter the db.

Additional context

No response

I've read and agree with the following

  • I've checked all open and closed issues and my request is not there.
  • I've checked all open and closed pull requests and my request is not there.
@MistarMuffin MistarMuffin added the enhancement New feature or request label May 7, 2024
@Ornias1993 Ornias1993 changed the title Immich Env Variable Passthrough [Immich] Disable database initialization May 8, 2024
@Ornias1993
Copy link
Member

@MistarMuffin Please next time correctly name your issues.
This has nothing to do with generalised env-var pass through

@Ornias1993
Copy link
Member

It will, likely, not be a user-facing checkbox though.

@MistarMuffin
Copy link
Author

@MistarMuffin Please next time correctly name your issues. This has nothing to do with generalised env-var pass through

There really is no need to chastize people for such things.

The title felt appropriate as generalized env-var passthrough does not appear to be working for this chart. I checked all containers in all pods using printenv and did not see the Extra Environmental Variables that I defined in the UI. I opened a support ticket on Discord to make sure my expectations were correct and was told to make this enhancement request.

Thank you for your help.

@Ornias1993
Copy link
Member

There really is no need to chastize people for such things.

I didn't "chastize" you, I requested you to file issues correctly so others done have to spend time fixing it.

The title felt appropriate as generalized env-var passthrough does not appear to be working for this chart.

It works correctly, it was never intended to cover more than the primary container on the primary pod.
It also is unittested so we're 100% sure it works correctly.


To be clear:

If you want as specific checkbox or env-var thats your PR title and you need to keep your description limited to that
If you want an other more general feature, you need to limit both your title and PR description to that.

We cannot have two completely different things in title and description as that gets confusing.

That being said:
I'm not sure all-container env-var fields will be added anytime soon, but feel free to make an enhancement request for that as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants