feat(next/app-dir): contextCache to control context values to add to cacheTag
#5458
Conversation
This change allows a user to specify `contextCache` method in the `experimental_nextCacheLink`, which lets one select the values from the context that should be considered when a `cacheTag` is generated. It also changes the way `cacheTag` is generated, taking care of the fact that the `cacheTag` cannot be longer then 256 characters, thus instead of stringifying input values, it will form a sha-256 hash of those. Implements trpc#5455
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dalechyn is attempting to deploy a commit to the trpc Team on Vercel. A member of the Team first needs to authorize it. |
|
@KATT, I need some help figuring this part out. Anyway, the commit should not break those as the |
|
@juliusmarminge, ci fails as webpack cannot import also found this thing: https://nextjs.org/docs/messages/node-module-in-edge-runtime, that might indicate that it would not be possible to use UPD: it is supported, https://nextjs.org/docs/pages/api-reference/edge#crypto-apis |
| * define which values from the context should be considered into the cache | ||
| * key | ||
| */ | ||
| cacheContext?: (ctx: inferRouterContext<TRouter>) => any[]; |
There was a problem hiding this comment.
while we don't have docs for these stuff yet, maybe include this in the example we have that's using this link so that people can know about it somehow.
i'd almost be inclined to make it required even since it's a vital part of getting the right cache key and making sure different users doesn't share the same cache entries?
There was a problem hiding this comment.
I suggest making this property | undefined instead of partial so that user is explicitly passing undefined if he doesn't want to manipulate the cache key.
There was a problem hiding this comment.
included in the example, and made the property | undefined.
|
@juliusmarminge i need some guidance here, i'm not sure wether I'm on the right or wrong direction. Starting to have a real type battle here. |
|
|
|
This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Closes: #5455
🎯 Changes
This change allows a user to specify
contextCachemethod in theexperimental_nextCacheLink, which lets one select the values from the context that should be considered when acacheTagis generated.It also changes the way
cacheTagis generated, taking care of the fact that thecacheTagcannot be longer then 256 characters, thus instead of stringifying input values, it will form a sha-256 hash of those.✅ Checklist