Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more properties to Iceberg $properties result #24812

Open
ebyhr opened this issue Jan 28, 2025 · 4 comments · May be fixed by #24922
Open

Add more properties to Iceberg $properties result #24812

ebyhr opened this issue Jan 28, 2025 · 4 comments · May be fixed by #24922
Assignees
@ozakidai
Labels
good first issue Good for newcomers iceberg Iceberg connector

Comments

@ebyhr
Copy link
Member

ebyhr commented Jan 28, 2025 •
edited
Loading

Trino:

CREATE TABLE test_iceberg AS SELECT 1 a;
TABLE "test_iceberg$properties";
               key               |  value
---------------------------------+---------
 write.format.default            | PARQUET
 write.parquet.compression-codec | zstd
(2 rows)

Spark:

SHOW TBLPROPERTIES default.test_iceberg;
current-snapshot-id	6491217016127971415
format	iceberg/PARQUET
format-version	2
write.format.default	PARQUET
write.parquet.compression-codec	zstd
Time taken: 0.034 seconds, Fetched 5 row(s)

The relevant class is PropertiesTable. The test class is BaseIcebergSystemTables.

Spark implementation is probably SparkTable#properties method.
@ebyhr ebyhr added good first issue Good for newcomers iceberg Iceberg connector labels Jan 28, 2025
@ozakidai
Copy link

Hi, let me work on this issue.

@ozakidai
Copy link

Hi, I'm still working on this. Could you give me a couple more days?

@ebyhr
Copy link
Member Author

ebyhr commented Jan 30, 2025

@ozakidai Sure, no rush. Please feel free to ping me on Slack if you have any questions.

@nikita-sheremet-java-developer
Copy link

nikita-sheremet-java-developer commented Feb 2, 2025 •
edited
Loading

@ozakidai

Could you please include location property too? It is very convinient sometimes to get table location but now only regexp can be used with show create table result.

Thanks in advance!

CC: @ebyhr

@sug-ghosh sug-ghosh mentioned this issue Feb 4, 2025
Closed
@ozakidai ozakidai linked a pull request Feb 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozakidai ozakidai

Labels
good first issue Good for newcomers iceberg Iceberg connector
Milestone
No milestone
3 participants
@ebyhr @nikita-sheremet-java-developer @ozakidai