Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent labels across repositories #24472

Open
mosabua opened this issue Dec 13, 2024 · 1 comment
Open

Use consistent labels across repositories #24472

mosabua opened this issue Dec 13, 2024 · 1 comment
Assignees
Labels
roadmap Top level issues for major efforts in the project

Comments

@mosabua
Copy link
Member

mosabua commented Dec 13, 2024

The Trino Go client and Trino Helm chart repositories have adopted a consistent set of labels to classify pull requests and changes for automated release notes generation on GitHub.

It would be useful to have consistency across all our repositories with these labels and eventually start using them in releases in other projects.

Immediate candidates where we can see benefits are the trino python client and the trino csharp client.

Even for other repositories it would be good to get into a habit of labelling PRs in a consistent manner and then we can potentially use this for release generation or even just for links to that use the labels in filters and maybe existing milestones we use in repositories like trino and trino-gateway.

The configuration in the YAML file from the go client

https://github.com/trinodb/trino-go-client/blob/master/.github/release.yml

Shows the current labels:

changelog:
  exclude:
    labels:
      - ignore-for-release
  categories:
    - title: Breaking changes
      labels:
        - breaking-change
    - title: Features
      labels:
        - enhancement
    - title: Bug fixes
      labels:
        - bug
    - title: Other changes
      labels:
        - "*"

Next step would be to discuss these labels and potentially agree to them as a standard set. We would also add that info to the contributor and maintainer docs.

Ideally we could define the labels on the org level but maybe we have to do that and roll it out per repository.

Also note that this setup with labels should also work with jreleaser (used for airlift release automation and potentially going to be used for others)

@mosabua mosabua added the roadmap Top level issues for major efforts in the project label Dec 13, 2024
@mosabua mosabua self-assigned this Dec 13, 2024
@mosabua
Copy link
Member Author

mosabua commented Dec 13, 2024

Fyi @trinodb/maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Top level issues for major efforts in the project
Development

No branches or pull requests

1 participant