Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hive4 tests failing with location must not be root path #24453

Open
mayankvadariya opened this issue Dec 12, 2024 · 1 comment
Open

Fix hive4 tests failing with location must not be root path #24453

mayankvadariya opened this issue Dec 12, 2024 · 1 comment

Comments

@mayankvadariya
Copy link
Contributor

Fix certain tests failing with location must not be root path in TestHive4OnDataLake.

Caused by: io.trino.hive.thrift.metastore.InvalidObjectException: test_sync_partition_on_bucket_root_39h7u99fo2 location must not be root path
	at io.trino.hive.thrift.metastore.ThriftHiveMetastore$create_table_result$create_table_resultStandardScheme.read(ThriftHiveMetastore.java:60697)
	at io.trino.hive.thrift.metastore.ThriftHiveMetastore$create_table_result$create_table_resultStandardScheme.read(ThriftHiveMetastore.java:60673)
	at io.trino.hive.thrift.metastore.ThriftHiveMetastore$create_table_result.read(ThriftHiveMetastore.java:60598)
	at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:93)
	at io.trino.hive.thrift.metastore.ThriftHiveMetastore$Client.recvCreateTable(ThriftHiveMetastore.java:1535)
	at io.trino.hive.thrift.metastore.ThriftHiveMetastore$Client.createTable(ThriftHiveMetastore.java:1522)
	at io.trino.plugin.hive.metastore.thrift.ThriftHiveMetastoreClient.createTable(ThriftHiveMetastoreClient.java:240)
	at io.trino.plugin.hive.metastore.thrift.ThriftHiveMetastore.lambda$createTable$31(ThriftHiveMetastore.java:846)
	at io.trino.plugin.hive.metastore.thrift.ThriftMetastoreApiStats.lambda$wrap$0(ThriftMetastoreApiStats.java:41)
	at io.trino.plugin.hive.util.RetryDriver.run(RetryDriver.java:117)
	at io.trino.plugin.hive.metastore.thrift.ThriftHiveMetastore.createTable(ThriftHiveMetastore.java:844)
@hashhar
Copy link
Member

hashhar commented Dec 12, 2024

this is something we should report to Hive folks instead and get them to fix properly.

Instead of fixing bug where DROP TABLE on root location threw NPE they simply disallowed creating such tables. That doesn't even help since people can have already existing tables pointing to root locations.

See https://issues.apache.org/jira/browse/HIVE-25912 + apache/hive#3009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants