Fix failure when commenting on non-lowercased view columns

Author: vlad-lyutenko

core/trino-main/src/main/java/io/trino/execution/CommentTask.java

@@ -175,7 +175,8 @@ private ViewColumn findAndCheckViewColumn(Comment statement, Session session, Vi
     {
         String columnName = statement.getName().getSuffix();
         ViewColumn viewColumn = viewDefinition.getColumns().stream()
-                .filter(column -> column.name().equals(columnName))
+                // TODO (https://github.com/trinodb/trino/issues/17) change to equals()
+                .filter(column -> column.name().equalsIgnoreCase(columnName))
                 .findAny()
                 .orElseThrow(() -> semanticException(COLUMN_NOT_FOUND, statement, "Column does not exist: %s", columnName));
         accessControl.checkCanSetColumnComment(session.toSecurityContext(), originalObjectName);

core/trino-main/src/test/java/io/trino/execution/TestCommentTask.java

@@ -19,6 +19,7 @@
 import io.trino.execution.warnings.WarningCollector;
 import io.trino.metadata.QualifiedObjectName;
 import io.trino.metadata.TableHandle;
+import io.trino.metadata.ViewColumn;
 import io.trino.security.AllowAllAccessControl;
 import io.trino.spi.connector.ConnectorTableMetadata;
 import io.trino.sql.tree.Comment;
@@ -33,6 +34,7 @@
 import static io.trino.spi.StandardErrorCode.COLUMN_NOT_FOUND;
 import static io.trino.spi.StandardErrorCode.TABLE_NOT_FOUND;
 import static io.trino.spi.connector.SaveMode.FAIL;
+import static io.trino.spi.type.BigintType.BIGINT;
 import static io.trino.sql.tree.Comment.Type.COLUMN;
 import static io.trino.sql.tree.Comment.Type.TABLE;
 import static io.trino.sql.tree.Comment.Type.VIEW;
@@ -143,6 +145,24 @@ public void testCommentViewColumn()
                 .hasMessageContaining("Column does not exist: %s", missingColumnName.getSuffix());
     }
 
+    @Test
+    public void testCommentOnMixedCaseViewColumn()
+    {
+        QualifiedObjectName viewName = qualifiedObjectName("existing_view");
+        metadata.createView(testSession, viewName, viewDefinition("SELECT 1", ImmutableList.of(new ViewColumn("Mixed", BIGINT.getTypeId(), Optional.empty()))), ImmutableMap.of(), false);
+        assertThat(metadata.isView(testSession, viewName)).isTrue();
+
+        QualifiedName columnNameLowerCase = qualifiedColumnName("existing_view", "mixed");
+        getFutureValue(setComment(COLUMN, columnNameLowerCase, Optional.of("new mixed column comment")));
+        assertThat(metadata.getView(testSession, viewName).get().getColumns().stream().filter(column -> "Mixed".equals(column.name())).collect(onlyElement()).comment())
+                .isEqualTo(Optional.of("new mixed column comment"));
+
+        QualifiedName columnNameMixedCase = qualifiedColumnName("existing_view", "Mixed");
+        getFutureValue(setComment(COLUMN, columnNameMixedCase, Optional.of("new Mixed column comment")));
+        assertThat(metadata.getView(testSession, viewName).get().getColumns().stream().filter(column -> "Mixed".equals(column.name())).collect(onlyElement()).comment())
+                .isEqualTo(Optional.of("new Mixed column comment"));
+    }
+
     @Test
     public void testCommentMaterializedViewColumn()
     {