Feature request: SQLAlchemy async

[hongbo-miao]

Describe the feature

It would be great to provide a SQLAlchemy async demo, thanks!

SQLAlchemy says it supports async since version 1.4

This repo readme says

trino.sqlalchemy is compatible with the latest 1.3.x and 1.4.x SQLAlchemy versions at the time of release of a particular version of the client.

https://docs.sqlalchemy.org/en/20/orm/extensions/asyncio.html

However, I cannot make them work.

I guess for SQLAlchemy, I need install

pip install sqlalchemy[asyncio]

This repo I need run

pip install trino[sqlalchemy]

Apparently, this does not exist 🥲

pip install trino[sqlalchemy[asyncio]]

I guess it may be blocked by this #3 (?)

Describe alternatives you've considered

Use https://github.com/mvanderlee/aiotrino instead. However, it would be great to support async officially including SQLAlchemy async. Thanks!

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[hovaesco]

Async SQLAlchemy is not supported currently for trino-python-client.

[hongbo-miao]

Thanks @hovaesco for clarification! I guess it would be a feature request. Just updated the title. Hopefully one day can support. 😃

[mvanderlee]

@hongbo-miao you can give aiotrino 0.3.0 a try. I've brought it to feature parity with trino-python-client 0.333.0 and now includes sqlalchemy support.

[lozbrown]

@hongbo-miao you can give aiotrino 0.3.0 a try. I've brought it to feature parity with trino-python-client 0.333.0 and now includes sqlalchemy support.

Including spooling?

[mvanderlee]

@hongbo-miao you can give aiotrino 0.3.0 a try. I've brought it to feature parity with trino-python-client 0.333.0 and now includes sqlalchemy support.

Including spooling?

Yes. I've copied the test suite as well and modified it for asyncio. It all passed. Beyond that I haven't done much sqlalchemy and spooling testing due to time constraints.

[lozbrown]

Nice, we use aiotrino for a few things so nice to know it's up to parity