Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Table - Adding HTML data in the ModusTableCellData and cell borders #1923

Closed
2 tasks done
Akashmuthumanickam opened this issue Dec 1, 2023 · 10 comments · Fixed by #3164
Closed
2 tasks done
Assignees
Labels
5 5 story points contribution Development will be done by members outside the Modus team external-request Bugs and features reported by individuals from other teams in Trimble improvement Improvement (Dev) to an existing control Version 1.x

Comments

@Akashmuthumanickam
Copy link

Prerequisites

Proposal

It would be good to add custom cell data similar to what we had in the modus-data-table. Currently, string, integer, and links are available in the cell data type.

Regarding the cell borders, requested to add row only borders similar to the one below.

image

Motivation and context

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

High

What product/project are you using Modus Components for ?

Flux - Connect web extensions

What is your team/division name ?

CPD

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

No response

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Hello @Akashmuthumanickam! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@rthanga1 rthanga1 added the improvement Improvement (Dev) to an existing control label Dec 18, 2023
@rthanga1 rthanga1 moved this from In Review to Refinement in Modus Web Components Dec 18, 2023
@rthanga1 rthanga1 added the contribution Development will be done by members outside the Modus team label Dec 18, 2023
@rthanga1
Copy link
Contributor

rthanga1 commented Dec 18, 2023

By default, the cells will have both row and column dividers but the row separator can be turned off (a property need to be exposed)
For the headers, the column separator will be always visible as the columns can be resized

@rthanga1
Copy link
Contributor

This is a improvement to the table control and this is modus approved. We can take it.

@rthanga1 rthanga1 added the 5 5 story points label Dec 19, 2023
@cjwinsor cjwinsor moved this from Refinement to In UX in Modus Web Components Jun 6, 2024
@enowak1031
Copy link

@prashanthr6383 Is there a reason why we need the UX for this one?

@prashanthr6383
Copy link
Collaborator

prashanthr6383 commented Aug 30, 2024

@prashanthr6383 Is there a reason why we need the UX for this one?

Hi @enowak1031, I think This needs to be checked by @prashanth-offcl

@prashanth-offcl prashanth-offcl moved this from In UX to In Review in Modus Web Components Aug 30, 2024
@prashanth-offcl
Copy link
Contributor

@enowak1031 I think it is get inputs on the second issue but it is already resolved so moving this back to InReview.

@Akashmuthumanickam

  1. Custom cell data - I'm not able to find it in modus-data-table, can you tell me what experience you are looking for?
  2. Option to remove table vertical border - You can set cellVerticalBorderless to true in displayOptions property to achieve this. Please check out this example here and let me know if that satisfies your requirement.

@enowak1031 enowak1031 moved this from In Review to Refinement in Modus Web Components Oct 14, 2024
@enowak1031 enowak1031 moved this from Refinement to To Do in Modus Web Components Feb 5, 2025
@enowak1031
Copy link

#1306 Related to this issue

@Kavin-Trimble
Copy link
Collaborator

Testing completed

@Kavin-Trimble
Copy link
Collaborator

@Akashmuthumanickam Could you take a look and provide your insights?

@Akashmuthumanickam
Copy link
Author

@Kavin-Trimble, Looking at https://deploy-preview-3164--moduswebcomponents.netlify.app/?path=/story/components-table--custom-cell, I am good with this.

@github-project-automation github-project-automation bot moved this from PR Review to Done in Modus Web Components Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 5 story points contribution Development will be done by members outside the Modus team external-request Bugs and features reported by individuals from other teams in Trimble improvement Improvement (Dev) to an existing control Version 1.x
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants