-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modus Table - Adding HTML data in the ModusTableCellData and cell borders #1923
Comments
Hello @Akashmuthumanickam! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to. Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR. |
By default, the cells will have both row and column dividers but the row separator can be turned off (a property need to be exposed) |
This is a improvement to the table control and this is modus approved. We can take it. |
@prashanthr6383 Is there a reason why we need the UX for this one? |
Hi @enowak1031, I think This needs to be checked by @prashanth-offcl |
@enowak1031 I think it is get inputs on the second issue but it is already resolved so moving this back to InReview.
|
#1306 Related to this issue |
Testing completed |
@Akashmuthumanickam Could you take a look and provide your insights? |
@Kavin-Trimble, Looking at https://deploy-preview-3164--moduswebcomponents.netlify.app/?path=/story/components-table--custom-cell, I am good with this. |
Prerequisites
Proposal
It would be good to add custom cell data similar to what we had in the modus-data-table. Currently, string, integer, and links are available in the cell data type.
Regarding the cell borders, requested to add row only borders similar to the one below.
Motivation and context
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
High
What product/project are you using Modus Components for ?
Flux - Connect web extensions
What is your team/division name ?
CPD
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
No response
The text was updated successfully, but these errors were encountered: