Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for binning where z* is not in the center of a bin #4

Open
trilnick opened this issue Sep 27, 2023 · 2 comments
Open

Allow for binning where z* is not in the center of a bin #4

trilnick opened this issue Sep 27, 2023 · 2 comments

Comments

@trilnick
Copy link
Owner

I'm not sure why it was set up this way to begin with. It's possible to change. However, since the calculations are done by binning, a highly asymmetrical placement could give weird results. I wonder if users can be trusted with this. In any case, perhaps I could add the option for users to input their own bins.

@trilnick
Copy link
Owner Author

Will need to tackle the issue of zstar between bins

@trilnick
Copy link
Owner Author

trilnick commented Oct 1, 2023

I though it could be easy-is to let users supply their own bins. But then I have to change a lot of the architecture:

  • Finding in which bin zstar is, and which are the other relevant bins.
  • Rather than calculating distances using binw, I'd have to use some sort of numbering of histogram bins.
  • Calculating probability masses is now done using binw as well, and that would need to change.

For now, it seems like the simplest solution for anyone who wants the kink/notch point to be between bins is to approximate this with narrower bins. This might make a noisier histogram, but perhaps that can be fixed by adding replications of the data with small variations (e.g. "jitter").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant