Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROL: Add override keyword to a few functions to squash -Winconsistent-override warnings from clang #13798

Closed
klmankt opened this issue Feb 10, 2025 · 3 comments
Closed

ROL: Add override keyword to a few functions to squash -Winconsistent-override warnings from clang #13798

klmankt opened this issue Feb 10, 2025 · 3 comments
Labels
client: Sierra All issues that primarily impacts SNL Sierra codes pkg: ROL type: enhancement Issue is an enhancement, not a bug

Comments

@klmankt
Copy link
Contributor

klmankt commented Feb 10, 2025

Enhancement

Need to add a few "override" keywords to Trilinos ROL package to prevent -Winconsistent-override warnings from clang when building SIERRA. Will submit a PR with necessary changes.

@dridzal
@klmankt klmankt added the type: enhancement Issue is an enhancement, not a bug label Feb 10, 2025
@github-actions GitHub Actions
Copy link

Automatic mention of @aj463

klmankt added a commit to klmankt/Trilinos that referenced this issue Feb 10, 2025
@klmankt
ROL: add some override keywords to eliminate -Winconsistent-override …
aaca022 
…warnings

for issue trilinos#13798
@klmankt klmankt mentioned this issue Feb 10, 2025
Merged
@MalachiTimothyPhillips MalachiTimothyPhillips added the client: Sierra All issues that primarily impacts SNL Sierra codes label Feb 11, 2025
klmankt added a commit to klmankt/Trilinos that referenced this issue Feb 11, 2025
@klmankt
ROL: add some override keywords to eliminate -Winconsistent-override …
a1491a8 
…warnings

for issue trilinos#13798

Signed-off-by: Kevin L. Manktelow <[email protected]>
@cgcgcg cgcgcg mentioned this issue Feb 11, 2025
Closed
@github-actions GitHub Actions
Copy link

Automatic mention of @aj463

@MalachiTimothyPhillips
Copy link

Closing since #13799 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client: Sierra All issues that primarily impacts SNL Sierra codes pkg: ROL type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MalachiTimothyPhillips @klmankt