-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulator build with poetry shell fails on Mac OS X with Clang 15 and buildgen v0.61 #3774
Labels
bug
Something isn't working as expected
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When trying to follow the documentation after fresh install, the
make build_unix
withinpoetry shell
environment, fails with an error.Firmware version and revision
Current (latest commit is
f8be07b
)main
branch.Desktop/smartphone setup (please complete the following information):
macOS Sonoma 14.4.1 (23E224)
clang --version
:To Reproduce
Steps to reproduce the behavior:
git clone --recurse-submodules https://github.com/trezor/trezor-firmware.git
cd trezor-firmware
poetry install
brew install scons sdl2 sdl2_image pkg-config llvm
rustup default nightly && rustup update
cd core
poetry shell
make build_unix
Expected behavior
Build is successful.
Screenshots
Additional context
The problem is described here, however it suggests problem is in Clang version 16 and above. But I am encountering this error with
clang 15
.However, there is a workaround in updating the
bindgen
crate to version0.62.0
and above (current version os0.69.4
):0.62.0
incore/embed/rust/Cargo.toml
bindgen::EnumVariation
it is needed to addis_global
variable when creating default enum style incore/embed/rust/build.rs
line37
:With the workaround applied, build is done and I am able to run the
emu.py
. Also all tests passed locally.After investigating this problem I suggest to update the version of
bindgen
to at leastv0.62.0
and do the necessary changes in the code.If someone gives me a green light, I can prepare the PR for this.
The text was updated successfully, but these errors were encountered: