test(core): fix broken log suppression in unit tests

[no changelog]

Author: M1nd3r

core/tests/README.md

@@ -30,3 +30,6 @@ class TestSomething(unittest.TestCase):
 ```
 
 Usage of `assert` is discouraged because it is not evaluated in production code (when `PYOPT=1`). Use `self.assertXY` instead, see `unittest.py`.
+
+## Logging
+By default, logging in unittests (using `trezor.log`) is disabled _even_ on debug builds. To enable logging, set `DISABLE_LOG` in `unittest.py` to `False`.

core/tests/test_apps.bitcoin.approver.py

@@ -32,8 +32,6 @@ class TestApprover(unittest.TestCase):
     if utils.USE_THP:
 
         def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
             thp_common.prepare_context()
 
     else:

core/tests/test_apps.bitcoin.authorization.py

@@ -25,8 +25,6 @@ class TestAuthorization(unittest.TestCase):
     if utils.USE_THP:
 
         def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
             thp_common.prepare_context()
 
     else:

core/tests/test_apps.bitcoin.keychain.py

@@ -20,8 +20,6 @@ class TestBitcoinKeychain(unittest.TestCase):
     if utils.USE_THP:
 
         def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
             thp_common.prepare_context()
 
         def setUp(self):
@@ -119,8 +117,6 @@ class TestAltcoinKeychains(unittest.TestCase):
     if utils.USE_THP:
 
         def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
             thp_common.prepare_context()
 
         def setUp(self):

core/tests/test_apps.common.keychain.py

@@ -24,8 +24,6 @@ class TestKeychain(unittest.TestCase):
     if utils.USE_THP:
 
         def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
             thp_common.prepare_context()
 
     else:

core/tests/test_apps.ethereum.keychain.py

@@ -83,8 +83,6 @@ def _check_keychain(self, keychain, slip44_id):
     if utils.USE_THP:
 
         def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
             thp_common.prepare_context()
 
         def setUp(self):

core/tests/test_storage.cache.py

@@ -37,11 +37,6 @@ class TestStorageCache(unittest.TestCase):
 
     if utils.USE_THP:
 
-        def setUpClass(self):
-            if __debug__:
-                thp_common.suppress_debug_log()
-            super().__init__()
-
         def setUp(self):
             self.interface = MockHID()
             cache.clear_all()

core/tests/test_trezor.wire.thp.crypto.py

@@ -77,11 +77,6 @@ class TestTrezorHostProtocolCrypto(unittest.TestCase):
             (0xFFFFFFFFFFFFFFFF, b"\x00\x00\x00\x00\xff\xff\xff\xff\xff\xff\xff\xff"),
         ]
 
-    def __init__(self):
-        if __debug__ and utils.USE_THP:
-            thp_common.suppress_debug_log()
-        super().__init__()
-
     def test_encryption(self):
         for v in self.vectors_enc:
             buffer = bytearray(v[3])

core/tests/test_trezor.wire.thp.writer.py

@@ -73,11 +73,6 @@ def await_until_result(self, task: Awaitable) -> Any:
             while True:
                 task.send(None)
 
-    def __init__(self):
-        if __debug__ and utils.USE_THP:
-            thp_common.suppress_debug_log()
-        super().__init__()
-
     def setUp(self):
         self.interface = MockHID()
         thp_ctx = ThpContext(self.interface)

core/tests/thp_common.py

@@ -29,11 +29,3 @@ def get_new_channel(iface: WireInterface) -> Channel:
         thp_ctx = ThpContext(iface)
         (iface_ctx,) = thp_ctx._iface_ctxs
         return Channel(channel_cache, iface_ctx, (ThpBuffer(), ThpBuffer()))
-
-
-if __debug__:
-    # Disable log.debug
-    def suppress_debug_log() -> None:
-        from trezor import log
-
-        log._min_level = 1