feat(core): add chunkify support for Solana SignTx

Author: obrusvit

common/protob/messages-solana.proto

@@ -76,6 +76,7 @@ message SolanaSignTx {
     required bytes serialized_tx = 2;                // serialized tx to be signed
     optional SolanaTxAdditionalInfo additional_info = 3;
     optional common.PaymentRequest payment_req = 4;  // SLIP-24 payment request
+    optional bool chunkify = 5;                      // display the address in chunks of 4 characters
 }
 
 /**

common/tests/fixtures/solana/sign_tx.compute_budget_program.json

@@ -70,6 +70,7 @@
       "description": "Transfer With Compute Budget Without Heap Confirmation",
       "parameters": {
         "address": "m/44'/501'/0'/0'",
+        "chunkify": true,
         "construct": {
           "version": null,
           "header": {
@@ -272,6 +273,7 @@
       "description": "Create Stake Account With Compute Budget",
       "parameters": {
         "address": "m/44'/501'/0'/0'",
+        "chunkify": true,
         "construct": {
           "version": null,
           "header": {

common/tests/fixtures/solana/sign_tx.predefined_transactions.json

@@ -8,6 +8,7 @@
       "description": "Transfer Token - predefined",
       "parameters": {
         "address": "m/44'/501'/0'/0'",
+        "chunkify": false,
         "construct": {
           "version": null,
           "header": {
@@ -61,6 +62,7 @@
       "description": "Transfer Token - predefined - with definitions",
       "parameters": {
         "address": "m/44'/501'/0'/0'",
+        "chunkify": true,
         "construct": {
           "version": null,
           "header": {
@@ -119,6 +121,7 @@
       "description": "Create Token Account and Transfer Token - predefined",
       "parameters": {
         "address": "m/44'/501'/0'/0'",
+        "chunkify": true,
         "construct": {
           "version": null,
           "header": {

core/.changelog.d/3446.fixed

@@ -0,0 +1 @@
+Allow chunkified recipient address in Solana transactions.

core/src/apps/solana/layout.py

@@ -311,6 +311,7 @@ async def confirm_system_transfer(
     signer_path: list[int],
     blockhash: bytes,
     verified_payment_request: PaymentRequest | None,
+    chunkify: bool,
 ) -> None:
     if verified_payment_request:
         await confirm_payment_request(
@@ -327,6 +328,7 @@ async def confirm_system_transfer(
             recipient=base58.encode(transfer_instruction.recipient_account[0]),
             title=TR.words__recipient,
             items=[(TR.words__blockhash, base58.encode(blockhash), True)],
+            chunkify=chunkify,
         )
 
         await confirm_custom_transaction(transfer_instruction.lamports, 9, "SOL", fee)
@@ -341,6 +343,7 @@ async def confirm_token_transfer(
     decimals: int,
     fee: Fee,
     blockhash: bytes,
+    chunkify: bool,
 ) -> None:
     items: list[StrPropertyType] = []
     if token_account != destination_account:
@@ -353,6 +356,7 @@ async def confirm_token_transfer(
         recipient=base58.encode(destination_account),
         title=TR.words__recipient,
         items=items,
+        chunkify=chunkify,
     )
 
     if is_unknown:
@@ -364,6 +368,7 @@ async def confirm_token_transfer(
             subtitle=TR.solana__unknown_token,
             address=base58.encode(token.mint),
             verb=TR.buttons__continue,
+            chunkify=chunkify,
             br_name="confirm_token_address",
             br_code=ButtonRequestType.ConfirmOutput,
         )
@@ -407,7 +412,7 @@ async def confirm_custom_transaction(
     )
 
 
-async def confirm_stake_withdrawer(withdrawer_account: bytes) -> None:
+async def confirm_stake_withdrawer(withdrawer_account: bytes, chunkify: bool) -> None:
     await show_danger(
         title=TR.words__important,
         content=TR.solana__stake_withdrawal_warning,
@@ -418,10 +423,11 @@ async def confirm_stake_withdrawer(withdrawer_account: bytes) -> None:
         title=TR.solana__stake_withdrawal_warning_title,
         address=base58.encode(withdrawer_account),
         br_name="confirm_stake_warning_address",
+        chunkify=chunkify,
     )
 
 
-async def confirm_claim_recipient(recipient_account: bytes) -> None:
+async def confirm_claim_recipient(recipient_account: bytes, chunkify: bool) -> None:
     await show_warning(
         content=TR.solana__claim_recipient_warning,
         br_name="confirm_claim_warning",
@@ -430,6 +436,7 @@ async def confirm_claim_recipient(recipient_account: bytes) -> None:
         title=TR.address_details__title_receive_address,
         address=base58.encode(recipient_account),
         br_name="confirm_claim_warning_address",
+        chunkify=chunkify,
     )
 
 
@@ -439,6 +446,7 @@ async def confirm_stake_transaction(
     blockhash: bytes,
     create: Instruction,
     delegate: Instruction,
+    chunkify: bool,
 ) -> None:
     from trezor.ui.layouts import confirm_solana_staking_tx
 
@@ -475,13 +483,15 @@ async def confirm_stake_transaction(
         fee_item=(fee_title, fee_str, True),
         fee_details=fee_items,
         blockhash_item=(TR.words__blockhash, base58.encode(blockhash), True),
+        chunkify=chunkify,
     )
 
 
 async def confirm_unstake_transaction(
     fee: Fee,
     signer_path: list[int],
     blockhash: bytes,
+    chunkify: bool,
 ) -> None:
     from trezor.ui.layouts import confirm_solana_staking_tx
 
@@ -498,6 +508,7 @@ async def confirm_unstake_transaction(
         fee_item=(fee_title, fee_str, True),
         fee_details=fee_items,
         blockhash_item=(TR.words__blockhash, base58.encode(blockhash), True),
+        chunkify=chunkify,
     )
 
 
@@ -506,6 +517,7 @@ async def confirm_claim_transaction(
     signer_path: list[int],
     blockhash: bytes,
     total_amount: int,
+    chunkify: bool,
 ) -> None:
     from trezor.ui.layouts import confirm_solana_staking_tx
 
@@ -525,6 +537,7 @@ async def confirm_claim_transaction(
         fee_item=(fee_title, fee_str, True),
         fee_details=fee_items,
         blockhash_item=(TR.words__blockhash, base58.encode(blockhash), True),
+        chunkify=chunkify,
     )
 
 

core/src/apps/solana/predefined_transaction.py

@@ -137,6 +137,7 @@ async def try_confirm_token_transfer_transaction(
     blockhash: bytes,
     additional_info: AdditionalTxInfo,
     verified_payment_request: PaymentRequest | None,
+    chunkify: bool,
 ) -> bool:
     from .definitions import unknown_token
     from .layout import confirm_payment_request, confirm_token_transfer
@@ -198,6 +199,7 @@ async def try_confirm_token_transfer_transaction(
             transfer_token_instructions[0].decimals,
             fee,
             blockhash,
+            chunkify,
         )
     return True
 
@@ -210,6 +212,7 @@ async def try_confirm_predefined_transaction(
     blockhash: bytes,
     additional_info: AdditionalTxInfo,
     verified_payment_request: PaymentRequest | None,
+    chunkify: bool,
 ) -> bool:
     from .layout import confirm_system_transfer
     from .transaction.instructions import SystemProgramTransferInstruction
@@ -228,7 +231,12 @@ async def try_confirm_predefined_transaction(
     if instructions_count == 1:
         if SystemProgramTransferInstruction.is_type_of(instructions[0]):
             await confirm_system_transfer(
-                instructions[0], fee, signer_path, blockhash, verified_payment_request
+                instructions[0],
+                fee,
+                signer_path,
+                blockhash,
+                verified_payment_request,
+                chunkify,
             )
             return True
 
@@ -238,6 +246,7 @@ async def try_confirm_predefined_transaction(
         signer_path,
         signer_public_key,
         blockhash,
+        chunkify,
     ):
         return True
 
@@ -248,6 +257,7 @@ async def try_confirm_predefined_transaction(
         blockhash,
         additional_info,
         verified_payment_request,
+        chunkify,
     )
 
 
@@ -257,6 +267,7 @@ async def try_confirm_staking_transaction(
     signer_path: list[int],
     signer_public_key: bytes,
     blockhash: bytes,
+    chunkify: bool,
 ) -> bool:
     from .transaction.instructions import (
         StakeProgramDeactivateInstruction,
@@ -291,7 +302,7 @@ def _match_instructions(*expected_types: Type[Instruction]) -> bool:
         if signer_public_key != create.base:
             return False
         if signer_public_key != init.withdrawer:
-            await confirm_stake_withdrawer(init.withdrawer)
+            await confirm_stake_withdrawer(init.withdrawer, chunkify)
         if signer_public_key != init.staker:
             return False
         if signer_public_key != delegate.stake_authority[0]:
@@ -312,6 +323,7 @@ def _match_instructions(*expected_types: Type[Instruction]) -> bool:
             blockhash=blockhash,
             create=create,
             delegate=delegate,
+            chunkify=chunkify,
         )
         return True
 
@@ -323,7 +335,7 @@ def _match_instructions(*expected_types: Type[Instruction]) -> bool:
                 return False
 
         await confirm_unstake_transaction(
-            fee=fee, signer_path=signer_path, blockhash=blockhash
+            fee=fee, signer_path=signer_path, blockhash=blockhash, chunkify=chunkify
         )
         return True
 
@@ -335,14 +347,15 @@ def _match_instructions(*expected_types: Type[Instruction]) -> bool:
             if signer_public_key != withdraw.withdrawal_authority[0]:
                 return False
             if signer_public_key != withdraw.recipient_account[0]:
-                await confirm_claim_recipient(withdraw.recipient_account[0])
+                await confirm_claim_recipient(withdraw.recipient_account[0], chunkify)
             total_amount += withdraw.lamports
 
         await confirm_claim_transaction(
             fee=fee,
             signer_path=signer_path,
             blockhash=blockhash,
             total_amount=total_amount,
+            chunkify=chunkify,
         )
 
         return True

core/src/apps/solana/sign_tx.py

@@ -106,6 +106,7 @@ async def sign_tx(
         transaction.blockhash,
         additional_tx_info,
         msg.payment_req,
+        bool(msg.chunkify),
     ):
         await confirm_instructions(
             address_n, signer_public_key, transaction, additional_tx_info

core/src/trezor/messages.py

@@ -1409,6 +1409,7 @@ def confirm_solana_recipient(
         items: Iterable[StrPropertyType] = (),
         br_name: str = "confirm_solana_recipient",
         br_code: ButtonRequestType = ButtonRequestType.ConfirmOutput,
+        chunkify: bool = False,
     ) -> Awaitable[None]:
         return confirm_value(
             title=title,
@@ -1418,6 +1419,7 @@ def confirm_solana_recipient(
             br_code=br_code,
             verb=TR.buttons__continue,
             info_items=items,
+            chunkify=chunkify,
         )
 
     def confirm_solana_tx(
@@ -1456,6 +1458,7 @@ async def confirm_solana_staking_tx(
         fee_item: StrPropertyType,
         fee_details: Iterable[StrPropertyType],
         blockhash_item: StrPropertyType,
+        chunkify: bool,
         br_name: str = "confirm_solana_staking_tx",
         br_code: ButtonRequestType = ButtonRequestType.SignTx,
     ) -> None:
@@ -1471,6 +1474,7 @@ async def confirm_solana_staking_tx(
             value=vote_account,
             verb=TR.buttons__continue,
             info=True,
+            chunkify=chunkify,
         )
 
         items: list[StrPropertyType] = [

core/src/trezor/ui/layouts/bolt/__init__.py

@@ -1005,13 +1005,23 @@ def confirm_value(
 
     from trezor.ui.layouts.menu import Details, Menu, confirm_with_menu
 
-    main = trezorui_api.confirm_with_info(
-        title=title,
-        items=((value, False),),
-        verb=verb or TR.buttons__confirm,
-        verb_info=INFO_ICON,
-        external_menu=True,
-    )
+    if chunkify:
+        main = trezorui_api.confirm_address(
+            title=title,
+            address=value,
+            address_label=None,
+            verb=verb or TR.buttons__confirm,
+            info_button=True,
+            chunkify=chunkify,
+        )
+    else:
+        main = trezorui_api.confirm_with_info(
+            title=title,
+            items=((value, False),),
+            verb=verb or TR.buttons__confirm,
+            verb_info=INFO_ICON,
+            external_menu=True,
+        )
 
     def item_factory(
         info_title: str, info_value: str
@@ -1389,6 +1399,7 @@ def confirm_solana_recipient(
         items: Iterable[StrPropertyType] = (),
         br_name: str = "confirm_solana_recipient",
         br_code: ButtonRequestType = ButtonRequestType.ConfirmOutput,
+        chunkify: bool = False,
     ) -> Awaitable[None]:
         return confirm_value(
             title=title,
@@ -1398,6 +1409,7 @@ def confirm_solana_recipient(
             br_code=br_code,
             verb=TR.buttons__continue,
             info_items=items,
+            chunkify=chunkify,
         )
 
     def confirm_solana_tx(