Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Journals associated with more than one policy #25

Closed
jpolka2 opened this issue May 11, 2018 · 3 comments
Closed

Journals associated with more than one policy #25

jpolka2 opened this issue May 11, 2018 · 3 comments

Comments

@jpolka2
Copy link
Contributor

jpolka2 commented May 11, 2018

BMJ appears in both romeo_1174 and romeo_25 which is its parent. At some point we may want to propagate missing info in the child policy from the parent policy and remove duplicate journals from the parent policies, in order to simplify the display.
@dhimmel
Copy link
Member

dhimmel commented May 11, 2018 •
edited
Loading

Ah so in the journals field I added every journal that was specifically associated with this policy as well as any journals that would inherit the policy. I thought it's important for curators to see every journal which may be affected by an annotation. However, perhaps it would make sense to split journals into two fields like journals and journals-subpolicies? If we want to make this change, let's add it to the laundry list in #20.

@jpolka
Copy link
Member

jpolka commented May 11, 2018

Will do - great idea!

@jpolka jpolka closed this as completed May 11, 2018
@jpolka jpolka mentioned this issue May 11, 2018
Open
@dhimmel
Copy link
Member

dhimmel commented May 11, 2018

I'm reopening this issue and we'll automatically close it when the journals field is split in production!

@dhimmel dhimmel reopened this May 11, 2018
dhimmel added a commit to dhimmel/policies-database that referenced this issue May 11, 2018
@dhimmel
In progress: split journals & journals-subpolicies
77056c7 
refs transpose-publishing#25
dhimmel added a commit to dhimmel/policies-database that referenced this issue May 11, 2018
@dhimmel
Split journals and child-journals in YAML
a529148 
Closes transpose-publishing#25

Enables migrations such that schema updates can occur while
retaining existing annotations.

RoMEO: create romeo/data/romeo_id-to-journals.json
@dhimmel dhimmel mentioned this issue May 11, 2018
Merged
dhimmel added a commit to dhimmel/policies-database that referenced this issue May 11, 2018
@dhimmel
Split journals and child-journals in YAML
af97238 
Closes transpose-publishing#25

Enables migrations such that schema updates can occur while
retaining existing annotations.

RoMEO: create romeo/data/romeo_id-to-journals.json
dhimmel added a commit that referenced this issue May 11, 2018
@dhimmel
Split journals and child-journals in YAML
63f88f8 
Merges #28
Closes #25

Enables migrations such that schema updates can occur while
retaining existing annotations.

RoMEO: create romeo/data/romeo_id-to-journals.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpolka @dhimmel @jpolka2