Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the plugins array and how to document target option #5021

Closed
2 tasks done
Tracked by #4764
Murderlon opened this issue Mar 26, 2024 · 2 comments · Fixed by #5145
Closed
2 tasks done
Tracked by #4764

Consider removing the plugins array and how to document target option #5021

Murderlon opened this issue Mar 26, 2024 · 2 comments · Fixed by #5145
Labels
4.0 For the 4.0 major version Feature

Comments

@Murderlon
Copy link
Member

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

Sometime ago we landed #4343, to auto discover and install plugins without target. We haven't updated the docs on this yet. We should also decide whether plugins can be removed in the major.

Solution

  • Remove plugins
  • Document you do not need target if you use Dashboard and update all examples to look more clean.

Alternatives

Only deprecate plugins. But if everything continues to work without it automatically, there would need to be an edge case to justify this.

@Murderlon Murderlon added Feature 4.0 For the 4.0 major version labels Mar 26, 2024
@Murderlon
Copy link
Member Author

@arturi can you recall a reason why we wouldn't want to remove plugins?

@arturi
Copy link
Contributor

arturi commented May 7, 2024

  1. I think we just weren't sure there was a better way than plugins — now there is.
  2. For backwards-compat, some people might be using it conditionally, like you have 5 plugins available in Uppy, but only 2 actually rendered.

Sounds like it’s fine to remove in 4.0 (and add back in a minor in case of a major screw up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 For the 4.0 major version Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants