-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with rendering multiple frames concurrently #1
Comments
@transitive-bullshit I don't know very well puppeteer or it's capabilities, but you could also load the same animation multiple times in the same page and render different frames on each instance. |
@bodymovin these are excellent points -- excited to test some of these possibilities out once I find some free time. 💯 |
Each frame is mostly independent of every other frame, so we could potentially render
N
frames concurrently by loading the same webpage inN
tabs / pages.This should be viewed as a perf experiment and optional toggle since it's performance will likely depend on the number of underlying CPUs, memory, and other platform considerations.
The only real change we'll have to be careful with in the implementation is our use of
image2pipe
for piping individual frames intoffmpeg
when renderingmp4
outputs. Since the frames won't necessarily be rendered in order anymore, we'll need to either:A) write these temp frames out to disk like we do for the gif renderer
or
B) buffer the frame images in memory and pipe them out only once all preceding frames have been piped
I'm leaning towards option B since it'll likely be more efficient but am open to other thoughts / feedback as well.
The text was updated successfully, but these errors were encountered: