-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to be able to find v3 Introduction Points #126
Comments
Hi emdee-is. Did you try? On first glance I'd expect so. |
I wouldn't have raised the issue if it worked!
Reading your comment #96 (comment) made me think that you knew it was " clearly a bug." and it looks like it hasn't been fixed. It's needed badly by any code that manipulates ExitNodes to make sure you don't block Introduction Points when blocking bad Exit Nodes. Could you fix the DDG onion in I think the examples should be run as a part of the release integration test suite and CI to make sure the code works and the examples are right; clearly if the examples have v2 onions they are at least a year out of date. Does the project use the CI facilities if github? I see ```tox.ini`` but it looks out of date (py37), and there is nothing in the README and no badges to show anything it is being run. I couldn't even get the unittests to run without erroring. This code is the foundation to a lot of software and has a good test suite so it would be good to have CI. |
Great point! Yup, the issue described in #96 would cause this. Try re-casting as suggested in its example - that should provide a simple workaround.
Thanks! I'm a big fan of tests. Stem used Jenkins for CI but iirc TPO discontinued it. I'd definitely like to try github's if I return to this project.
Please reach out to 'gk at torproject dot org' for fixes. He assumed maintainership when I left tor. |
Why could I do that: the code isn't even valid Python
I think you should do that if he "assumed maintainership", because if he did, he'd be active in the repo replying to issues and fixing things:
and the person you handed it off to isn't active. |
Hi emdee-is. The get_hidden_service_descriptor() method should accept both V2 and V3 addresses. The bug described in #96 is that Stem provides a V2 object when presented with a V3 address. You can sidestep this by re-casting the object as demonstrated in the comment's code snippet...
Yup, they aren't but that's because they have other work and Stem isn't a squeaky wheel. Guess I made Stem too solid. ;P Nobody complains about Stem's lack of maintenance so they understandably conclude that it's not a priority. |
Introduction points now work with 1.8.2 You may want to include or adopt https://git.plastiras.org/emdee/stem_examples which are the examples from stem.torproject.org/examples and make a good testsuite. There are some problems that are showing up there. |
I need to be able to find v3 Introduction Points - it is possible?
stem/docs/_static/example/introduction_points.py
needs up dating to haveDDG's v3 address:
duckduckgogg42xjoc72x3sjasowoarfbgcmvfimaftt6twagswzczad
and then the code needs to be made to work. Can it be done in V3?
The text was updated successfully, but these errors were encountered: