Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the ABNF #650

Closed
workingjubilee opened this issue Aug 16, 2019 · 7 comments
Closed

Verify the ABNF #650

workingjubilee opened this issue Aug 16, 2019 · 7 comments
Assignees
Labels

Comments

@workingjubilee
Copy link
Contributor

I like that progress is being made on various tweaks to the ABNF to bring it closer to the README's requirements, I have to ask, even at the risk of sounding dumb:

What would verifying the ABNF even mean? https://github.com/toml-lang/toml/projects/1#card-21107891

@pradyunsg
Copy link
Member

What would verifying the ABNF even mean? toml-lang/toml/projects/1#card-21107891

Making sure that all the rules are in sync with what the README states and to sit and try to identify things like #640.

@eksortso

This comment has been minimized.

@workingjubilee

This comment has been minimized.

@eksortso

This comment has been minimized.

@pradyunsg
Copy link
Member

pradyunsg commented Nov 6, 2019

I don't think anything other than #640 is left here.

I was wrong; this got posted accidentally. 🙈

@pradyunsg pradyunsg self-assigned this Dec 12, 2019
@pradyunsg
Copy link
Member

Now, I actually think #640 (and open PRs) are the only thing left to do here.

@pradyunsg
Copy link
Member

I went through the ABNF today -- while I'm sure there's some degree of inattention-due-to-familiarity concerns, the ABNF seems to be pretty much in sync with the README so I'm gonna go ahead and close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants