Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed-type arrays are still invalid, aren't they? #3

Closed
eksortso opened this issue Aug 31, 2019 · 3 comments
Closed

Mixed-type arrays are still invalid, aren't they? #3

eksortso opened this issue Aug 31, 2019 · 3 comments

Comments

@eksortso
Copy link

The example at the top of the page has the following two lines:

[clients]
data = [ ["delta", "phi"], 3.14159 ]

The problem is the value of data. which is a mixed-type array, which is invalid in TOML v0.5.0. Although there's an open issue regarding whether mixed-type arrays ought to be allowed, that issue is tagged post-1.0.

So assuming the issue isn't pressed before v1.0.0, do you think we need to remove or replace the mixed-type array from the lead example?

@cannikin
Copy link
Contributor

cannikin commented Sep 1, 2019

I got it from this example in the README but tried to shorten it to fit the width of an iPhone X:

[clients]
data = [ ["gamma", "delta"], [1, 2] ]

If I just wrap my 3.14 in an array would we be good to go?

@eksortso
Copy link
Author

eksortso commented Sep 1, 2019

That'd definitely do it. Array of arrays.

@pradyunsg
Copy link
Member

Yea. Let's go with array of arrays here. The updated example above seems fine to me.

I'm gonna eagerly close this issue, since we have a resolution.

@pradyunsg pradyunsg mentioned this issue Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants