Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] AsyncMessaging: refactor existing class, usages and assets #2744

Open
Tracked by #2677
cuserox opened this issue May 10, 2024 · 0 comments
Open
Tracked by #2677

[DX] AsyncMessaging: refactor existing class, usages and assets #2744

cuserox opened this issue May 10, 2024 · 0 comments

Comments

@cuserox
Copy link

cuserox commented May 10, 2024

馃摎 Context

Before replacing the current asynchronous messaging setup, we could get it in a more decoupled state by improving areas of the existing code. Precedent to: #2743

馃洜 Acceptance Criteria

Centered effort around the class instantiating the channel setup AsyncMessageChannel

Some improvement ideas:

  • Use different methods to postMessages from figma.ui vs parent
  • isInFigmaSandbox needs a better name
  • Include error handling for prod / dev (including Sentry if necessary)
  • Group all types in the same files and area of the project
  • attachMessageListener can be further split out and tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 馃摛 Ready for dev
Development

No branches or pull requests

1 participant