Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move execution listener to a separate module #1002

Closed
wants to merge 11 commits into from
Closed

Move execution listener to a separate module #1002

wants to merge 11 commits into from

Conversation

hantsy
Copy link

@hantsy hantsy commented Apr 12, 2023

fixes #997

@hantsy hantsy marked this pull request as draft May 24, 2023 13:34
@hantsy
Copy link
Author

hantsy commented May 24, 2023

@bennetelli I tried to add a test for the test execution listener, but I am not sure I could add more assertions to verify the operation in the TogglzTestExecutionListener.

@hantsy hantsy marked this pull request as ready for review May 24, 2023 14:22
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.17 🎉

Comparison is base (6e19b44) 56.04% compared to head (86a7bdd) 56.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1002      +/-   ##
============================================
+ Coverage     56.04%   56.21%   +0.17%     
- Complexity      921      924       +3     
============================================
  Files           178      178              
  Lines          4527     4527              
  Branches        597      597              
============================================
+ Hits           2537     2545       +8     
+ Misses         1832     1822      -10     
- Partials        158      160       +2     
Impacted Files Coverage Δ
...ogglz/spring/test/TogglzTestExecutionListener.java 50.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pom.xml Outdated Show resolved Hide resolved
samples/pom.xml Outdated Show resolved Hide resolved
samples/spring-boot-hello-world/pom.xml Outdated Show resolved Hide resolved
.github/workflows/maven.yml Show resolved Hide resolved
Copy link
Member

@bennetelli bennetelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this once again. IMO it would be better to integrate it in the existing spring boot starters instead of having to add the starter and the spring-test dependency to every project.

In the end there should be the spring-boot-starter only if it is possible.

@hantsy
Copy link
Author

hantsy commented May 31, 2023

Making it standalone is better.

Like the existing spring boot starters example, spring-boot-starter-web and spring-boot-starter-test, spring-boot-starter-security and spring-security-test...

None of the starters include a test module.

If adding it into the togglze-starter, it will affect the test running described as I have encountered in the issue comments, I have to exclude it again.

@bennetelli
Copy link
Member

I think we need to find a better way to achieve this. With these changes, projects using togglz with Feature enum would not need to add the new spring-test dependency, but projects using the application.yml file to declare their feature toggles would need to do it.

IMO that should be hidden for the users and they should not have to add an additional dependency in this case.

@hantsy hantsy closed this Jul 29, 2023
@hantsy
Copy link
Author

hantsy commented Jul 29, 2023

We gave up using this module in projects. In the past years of using Spring Boot in projects, I never encountered a case like this, adding a module destroyed the project test contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TogglzTestExecutionListener out of togglz-spring-core module
3 participants