[chore] Move to Rust v1.85 (MystenLabs#21320)

## Description 

A clean move to Rust v1.85.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:

Author: stefan-mysten

consensus/config/src/committee.rs

@@ -57,8 +57,8 @@ impl Committee {
         }
     }
 
-    /// -----------------------------------------------------------------------
-    /// Accessors to Committee fields.
+    // -----------------------------------------------------------------------
+    // Accessors to Committee fields.
 
     pub fn epoch(&self) -> Epoch {
         self.epoch
@@ -91,8 +91,8 @@ impl Committee {
             .map(|(i, a)| (AuthorityIndex(i as u32), a))
     }
 
-    /// -----------------------------------------------------------------------
-    /// Helpers for Committee properties.
+    // -----------------------------------------------------------------------
+    // Helpers for Committee properties.
 
     /// Returns true if the provided stake has reached quorum (2f+1).
     pub fn reached_quorum(&self, stake: Stake) -> bool {
@@ -104,7 +104,7 @@ impl Committee {
         stake >= self.validity_threshold()
     }
 
-    /// Coverts an index to an AuthorityIndex, if valid.
+    /// Converts an index to an AuthorityIndex, if valid.
     /// Returns None if index is out of bound.
     pub fn to_authority_index(&self, index: usize) -> Option<AuthorityIndex> {
         if index < self.authorities.len() {

consensus/core/src/network/metrics_layer.rs

@@ -7,9 +7,9 @@ use prometheus::HistogramTimer;
 
 use super::metrics::NetworkRouteMetrics;
 
-/// Tower layer adapters that allow specifying callbacks for request and response handling
-/// exist for both anemo and http. So the metrics layer implementation can be reused across
-/// networking stacks.
+// Tower layer adapters that allow specifying callbacks for request and response handling
+// exist for both anemo and http. So the metrics layer implementation can be reused across
+// networking stacks.
 
 pub(crate) trait SizedRequest {
     fn size(&self) -> usize;

consensus/core/src/test_dag_parser.rs

@@ -51,7 +51,6 @@ use crate::{
 /// dag_builder.print(); // print the parsed DAG
 /// dag_builder.persist_all_blocks(dag_state.clone()); // persist all blocks to DagState
 /// ```
-
 pub(crate) fn parse_dag(dag_string: &str) -> IResult<&str, DagBuilder> {
     let (input, _) = tuple((tag("DAG"), multispace0, char('{')))(dag_string)?;
 

crates/mysten-common/src/sync/notify_read.rs

@@ -142,7 +142,7 @@ pub struct Registration<'a, K: Eq + Hash + Clone, V: Clone> {
     registration: Option<(K, oneshot::Receiver<V>)>,
 }
 
-impl<'a, K: Eq + Hash + Clone + Unpin, V: Clone + Unpin> Future for Registration<'a, K, V> {
+impl<K: Eq + Hash + Clone + Unpin, V: Clone + Unpin> Future for Registration<'_, K, V> {
     type Output = V;
 
     fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
@@ -160,7 +160,7 @@ impl<'a, K: Eq + Hash + Clone + Unpin, V: Clone + Unpin> Future for Registration
     }
 }
 
-impl<'a, K: Eq + Hash + Clone, V: Clone> Drop for Registration<'a, K, V> {
+impl<K: Eq + Hash + Clone, V: Clone> Drop for Registration<'_, K, V> {
     fn drop(&mut self) {
         if let Some((key, receiver)) = self.registration.take() {
             mem::drop(receiver);

crates/mysten-metrics/src/guards.rs

@@ -16,7 +16,7 @@ impl<'a> GaugeGuard<'a> {
     }
 }
 
-impl<'a> Drop for GaugeGuard<'a> {
+impl Drop for GaugeGuard<'_> {
     fn drop(&mut self) {
         self.0.dec();
     }
@@ -41,7 +41,7 @@ pub struct GaugeGuardFuture<'a, F: Sized> {
     _guard: GaugeGuard<'a>,
 }
 
-impl<'a, F: Future> Future for GaugeGuardFuture<'a, F> {
+impl<F: Future> Future for GaugeGuardFuture<'_, F> {
     type Output = F::Output;
 
     fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {

crates/mysten-metrics/src/histogram.rs

@@ -309,7 +309,7 @@ impl HistogramReporter {
     }
 }
 
-impl<'a> Drop for HistogramTimerGuard<'a> {
+impl Drop for HistogramTimerGuard<'_> {
     fn drop(&mut self) {
         self.histogram
             .report(self.start.elapsed().as_millis() as u64);

crates/mysten-metrics/src/metered_channel.rs

@@ -162,7 +162,7 @@ impl<'a, T> Permit<'a, T> {
     }
 }
 
-impl<'a, T> Drop for Permit<'a, T> {
+impl<T> Drop for Permit<'_, T> {
     fn drop(&mut self) {
         // in the case the permit is dropped without sending, we still want to decrease the occupancy of the channel
         if self.permit.is_some() {
@@ -253,11 +253,10 @@ impl<T> Sender<T> {
 }
 
 ////////////////////////////////
-/// Stream API Wrappers!
+// Stream API Wrappers!
 ////////////////////////////////
 
 /// A wrapper around [`crate::metered_channel::Receiver`] that implements [`Stream`].
-///
 #[derive(Debug)]
 pub struct ReceiverStream<T> {
     inner: Receiver<T>,
@@ -313,7 +312,7 @@ impl<T> From<Receiver<T>> for ReceiverStream<T> {
 // TODO: add prom metrics reporting for gauge and migrate all existing use cases.
 
 ////////////////////////////////////////////////////////////////
-/// Constructor
+// Constructor
 ////////////////////////////////////////////////////////////////
 
 /// Similar to `mpsc::channel`, `channel` creates a pair of `Sender` and `Receiver`

crates/mysten-metrics/src/monitored_mpsc.rs

@@ -169,7 +169,7 @@ impl<'a, T> Permit<'a, T> {
     }
 }
 
-impl<'a, T> Drop for Permit<'a, T> {
+impl<T> Drop for Permit<'_, T> {
     fn drop(&mut self) {
         // In the case the permit is dropped without sending, we still want to decrease the occupancy of the channel.
         // Otherwise, receiver should be responsible for decreasing the inflight gauge.

crates/sui-core/src/authority.rs

@@ -4425,8 +4425,7 @@ impl AuthorityState {
     ) -> SuiResult<Option<VerifiedSignedTransaction>> {
         let lock_info = self
             .get_object_cache_reader()
-            .get_lock(*object_ref, epoch_store)
-            .map_err(SuiError::from)?;
+            .get_lock(*object_ref, epoch_store)?;
         let lock_info = match lock_info {
             ObjectLockStatus::LockedAtDifferentVersion { locked_ref } => {
                 return Err(UserInputError::ObjectVersionUnavailableForConsumption {

crates/sui-core/src/authority/authority_per_epoch_store.rs

@@ -571,8 +571,7 @@ pub struct AuthorityEpochTables {
     #[allow(dead_code)]
     randomness_rounds_written: DBMap<(), ()>,
 
-    /// Tables for recording state for RandomnessManager.
-
+    // Tables for recording state for RandomnessManager.
     /// Records messages processed from other nodes. Updated when receiving a new dkg::Message
     /// via consensus.
     pub(crate) dkg_processed_messages_v2: DBMap<PartyId, VersionedProcessedMessage>,
@@ -1560,18 +1559,13 @@ impl AuthorityPerEpochStore {
             self.consensus_quarantine.read().is_empty(),
             "get_last_consensus_stats should only be called at startup"
         );
-        match self
-            .tables()?
-            .get_last_consensus_stats()
-            .map_err(SuiError::from)?
-        {
+        match self.tables()?.get_last_consensus_stats()? {
             Some(stats) => Ok(stats),
             None => {
                 let indices = self
                     .tables()?
                     .get_last_consensus_index()
-                    .map(|x| x.unwrap_or_default())
-                    .map_err(SuiError::from)?;
+                    .map(|x| x.unwrap_or_default())?;
                 Ok(ExecutionIndicesWithStats {
                     index: indices,
                     hash: 0, // unused