Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config file name too generic? #27

Open
olesenm opened this issue May 13, 2024 · 4 comments
Open

config file name too generic? #27

olesenm opened this issue May 13, 2024 · 4 comments

Comments

@olesenm
Copy link

olesenm commented May 13, 2024

I'm currently still using gzstream, but was looking for an updated interface and bxzstr looks pretty good!
However, the config.hpp file could potentially cause ambiguity depending on what the final include path looks like.
Would it be possible to rename as bxzstr_config.hpp (for example), to preclude any such problems (or did I miss something)?

@tmaklin
Copy link
Owner

tmaklin commented May 24, 2024

Hi, thanks for the report, I've run in to the same problem with the file being being too generic and agree this makes sense to change. I'll look into it.

@olesenm
Copy link
Author

olesenm commented May 29, 2024

Hi, thanks for the report, I've run in to the same problem with the file being being too generic and agree this makes sense to change. I'll look into it.

I have actually made a number of other changes as well (to avoid other include name collisions). Unfortunately they are on another machine and I don't have access to the changeset for the next two weeks (machine is offline). If you want to hang on until then, I can post them for you to inspect/grab/merge as you see fit.

@tmaklin
Copy link
Owner

tmaklin commented May 30, 2024

Yes, this would be useful if you can share it. No hurry though.

olesenm added a commit to olesenm/bxzstr that referenced this issue Jun 10, 2024
 tmaklin#27)

- place strict_fstream into bxzstr namespace to avoid name clashes
@olesenm
Copy link
Author

olesenm commented Jun 10, 2024

added to pull-request 28 but not well tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants