Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling matchSnapshot without parameter #1

Open
tpluscode opened this issue Jun 25, 2020 · 1 comment
Open

Calling matchSnapshot without parameter #1

tpluscode opened this issue Jun 25, 2020 · 1 comment

Comments

@tpluscode
Copy link

Finally, I found a snapshot matcher which actually works! Thank you

My only suggestion would be to have it called without the this

-      expect(after.instances.get(form)).to.matchSnapshot(this)
+      expect(after.instances.get(form)).to.matchSnapshot()
@tlameiras
Copy link
Owner

tlameiras commented Jul 21, 2020

Hi @tpluscode 👋

This fix will require some refactoring and will correspond to a major version update.

In any case, I will try to bring this improvement as soon as possible 😄

Thanks for your feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants