From 28ca15f783da222c124e0a87d748ef28611e1f50 Mon Sep 17 00:00:00 2001
From: jaydonkrooss <147423601+jaydonkrooss@users.noreply.github.com>
Date: Mon, 27 Nov 2023 13:32:53 -0500
Subject: [PATCH] #1250: Add patterns to Resource Access visualizations (#1553)

* Create patterns for accessibility on resource access chart

* Drop old commented lines, add pattern description

* revert accessed resources to solid color

* fix linting, add camelCase to pattern label

* rename defs variable

* clean up svg defs variable

---------

Co-authored-by: Jaydon Krooss <jkrooss@m-dvf4tlw5mw.local>
---
 .../d3/createResourceAccessChart.js           | 36 ++++++++++++++-----
 1 file changed, 28 insertions(+), 8 deletions(-)

diff --git a/assets/src/components/d3/createResourceAccessChart.js b/assets/src/components/d3/createResourceAccessChart.js
index 93b2a81f..30fd268f 100644
--- a/assets/src/components/d3/createResourceAccessChart.js
+++ b/assets/src/components/d3/createResourceAccessChart.js
@@ -38,13 +38,13 @@ const toolTip = tip.attr('class', 'd3-tip')
   })
 
 function appendLegend (svg) {
-  const legendBoxLength = 10
-  const legendBoxTextInterval = 15
+  const legendBoxLength = 13
+  const legendBoxTextInterval = 20
   const legendInterval = 20
   const legendY = -50
 
   const legendLabels = [
-    ['Resources I haven\'t viewed', notAccessedResourceColor],
+    ['Resources I haven\'t viewed', 'url(#notAccessedPattern)'],
     ['Resources I\'ve viewed', accessedResourceColor]
   ]
 
@@ -190,7 +190,7 @@ function createResourceAccessChart ({ data, width, height, domElement }) {
       .attr('class', 'bar')
       .attr('fill', d => d.self_access_count > 0
         ? accessedResourceColor
-        : notAccessedResourceColor
+        : 'url(#notAccessedPattern)'
       )
       .on('focus', (e, d) => {
         moveBrushOnFocus(e, d.resource_name)
@@ -210,7 +210,7 @@ function createResourceAccessChart ({ data, width, height, domElement }) {
       .enter()
       .append('text')
       .attr('class', 'label')
-      .attr('x', d => mainXScale(d.total_percent) + 3 + mainMargin.left)
+      .attr('x', d => mainXScale(d.total_percent) + 40 + mainMargin.left)
       .attr('y', d => mainYScale(d.resource_name) + mainYScale.bandwidth() / 2 + mainMargin.top)
       .attr('dx', -10)
       .attr('dy', '.35em')
@@ -286,7 +286,7 @@ function createResourceAccessChart ({ data, width, height, domElement }) {
     d3.select('.miniGroup').selectAll('.bar')
       .style('fill', d => d.self_access_count > 0
         ? accessedResourceColor
-        : notAccessedResourceColor
+        : 'url(#notAccessedPattern)'
       )
       .style('opacity', d => selected.includes(d.resource_name)
         ? 1
@@ -393,8 +393,10 @@ function createResourceAccessChart ({ data, width, height, domElement }) {
     .on('mousedown.brush', brushcenter)
     .on('touchstart.brush', brushcenter, { passive: true })
 
+  const svgDefinitions = svg.append('defs')
+
   // Clips
-  svg.append('defs')
+  svgDefinitions
     .append('clipPath')
     .attr('id', 'clip')
     .append('rect')
@@ -402,6 +404,24 @@ function createResourceAccessChart ({ data, width, height, domElement }) {
     .attr('width', mainWidth + mainMargin.left)
     .attr('height', mainHeight)
 
+  // Pattern for not accessed: black stripes on gray background
+  svgDefinitions
+    .append('pattern')
+    .attr('id', 'notAccessedPattern')
+    .attr('width', 10)
+    .attr('height', 10)
+    .attr('patternUnits', 'userSpaceOnUse')
+    .attr('patternTransform', 'rotate(45)')
+    .append('rect')
+    .attr('width', 10)
+    .attr('height', 10)
+    .attr('fill', notAccessedResourceColor)
+  svgDefinitions.select('#notAccessedPattern')
+    .append('rect')
+    .attr('width', 2)
+    .attr('height', 10)
+    .attr('fill', 'black')
+
   // Inject data
   // Domain
   mainXScale.domain([0, d3.max(resourceData, d => d.total_percent)])
@@ -445,7 +465,7 @@ function createResourceAccessChart ({ data, width, height, domElement }) {
     .attr('class', 'bar')
     .attr('fill', d => d.self_access_count > 0
       ? accessedResourceColor
-      : notAccessedResourceColor
+      : 'url(#notAccessedPattern)'
     )
 
   // Add brush to main chart