Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newPointMarker is removed from map when parent marker is out of bounds #17

Open
stharvey opened this issue Jul 8, 2020 · 0 comments
Open

Comments

@stharvey
Copy link

stharvey commented Jul 8, 2020

Hello,

This is a great plugin, thanks a lot for that.

Just a quick comment that when _showBoundMarkers() is called on moveend and zoomeend the edit point (newPointMarker) will be removed if the parent marker is off-screen.

I beleive I've fixed this by changing:

that._setMarkerVisible(marker.newPointMarker, markerNo > 0 && bounds.contains(marker.getLatLng()));

to

that._setMarkerVisible(marker.newPointMarker, markerNo > 0 && bounds.contains(marker.newPointMarker.getLatLng()));

But i'm not sure if that's going to have any other consequences?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant