Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook support (fixes #71) #104

Open
wants to merge 101 commits into
base: master
Choose a base branch
from
Open

Notebook support (fixes #71) #104

wants to merge 101 commits into from

Conversation

bigbug
Copy link
Collaborator

@bigbug bigbug commented Apr 15, 2022

Work in progress for creating notebook renderer support.

The extension shall listen for the following mime types:

  • application/json
  • application/json+graphviz-interactive-preview
  • text/plain
  • text/x-json
  • text/x-graphviz
  • text/x-dot

@bigbug
Copy link
Collaborator Author

bigbug commented Apr 15, 2022

Toolbar has been recreated with react for the notebook view:
Screenshot 2022-04-15 at 21 20 41

@bigbug
Copy link
Collaborator Author

bigbug commented Apr 16, 2022

Rendering within a notebook:
Screenshot 2022-04-16 at 13 06 00

@bigbug
Copy link
Collaborator Author

bigbug commented Apr 16, 2022

File saving and communication with main extension (needed especially for file saving) now works.

@bigbug
Copy link
Collaborator Author

bigbug commented Apr 17, 2022

Problem:
Zoom on Image -> Change render engine -> zoom again
There is a blip the zoom

@bigbug bigbug linked an issue Jan 22, 2023 that may be closed by this pull request
@bigbug bigbug requested a review from tintinweb January 22, 2023 21:27
@bigbug bigbug marked this pull request as ready for review January 22, 2023 21:27
@bigbug bigbug linked an issue Jan 22, 2023 that may be closed by this pull request
@bigbug bigbug changed the title [DRAFT] Notebook support (fixes #71) Notebook support (fixes #71) Jan 29, 2023
@tintinweb
Copy link
Owner

tintinweb commented Feb 7, 2023

The edge tracing seems to be off when searching for nodes/edges:

this version (a and b2 should not be highlighted).
image

appears to be correct in the currently released version:
xx

@bigbug
Copy link
Collaborator Author

bigbug commented Mar 4, 2023

@tintinweb : Search has been fixed

@bigbug bigbug mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants