-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCSSDistance with KNN #476
Comments
and could you default LCSS to window size 3 and epsilon 0.05? ta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the code here
if(limit != Double.POSITIVE_INFINITY) { // check if there's a limit set
// if so then reverse engineer the max LCSS distance and replace the limit
// this is just the inverse of the return value integer rounded to an LCSS distance
limit = (int) ((1 - limit) * aLength) + 1; // must have plus 1 due to int rounding. Otherwise the value
// is potentially slightly too low, causing early early abandon
}
is causing a bug. It means that many distances that are in fact lower than "limit" are early abandonded/set to infinity. I am not sure if it misuse, and limit is meant to be a width parameter, or just incorrectly calculated.
Removing the limit as such before this code
limit = Double.POSITIVE_INFINITY;
makes the output match with the older LCSS, and without the limit the distances are identical
The text was updated successfully, but these errors were encountered: