fix: warning should fire when both proxy and multiuser rotation enabled (#66)

Author: ahammond

src/aurora.ts

@@ -257,7 +257,7 @@ export class Aurora extends Construct {
   constructor(scope: Construct, id: Namer, props: AuroraProps) {
     super(scope, id.pascal);
 
-    if (!props.skipAddRotationMultiUser && props.skipProxy) {
+    if (!props.skipAddRotationMultiUser && !props.skipProxy) {
       Annotations.of(this).addWarning(
         'AWS RDS Proxy is fundamentally incompatible with the MultiUser rotation scheme. Please see README.md for more information.',
       );

test/aurora.test.ts

@@ -30,6 +30,7 @@ let stack: Stack;
 let kmsKey: IKey;
 let vpc: IVpc;
 let template: Template;
+let annotations: Annotations;
 let defaultAuroraProps: AuroraProps;
 let aurora: Aurora;
 
@@ -39,6 +40,7 @@ const createAurora = function (props?: AuroraProps) {
     ...props,
   });
   template = Template.fromStack(stack);
+  annotations = Annotations.fromStack(stack);
 };
 
 describe('Aurora', () => {
@@ -167,6 +169,24 @@ describe('Aurora', () => {
       defaultAuroraProps = { databaseName, kmsKey, vpc };
     });
 
+    describe('multiuser rotation and proxy incompatibility', () => {
+      const incompatibilityWarning = Match.stringLikeRegexp(
+        'AWS RDS Proxy is fundamentally incompatible with the MultiUser rotation scheme.',
+      );
+      it('warns when both are enabled', () => {
+        createAurora(defaultAuroraProps);
+        annotations.hasWarning('*', incompatibilityWarning);
+      });
+      it('does not warn when multiuser rotation disabled', () => {
+        createAurora({ ...defaultAuroraProps, skipAddRotationMultiUser: true });
+        annotations.hasNoWarning('*', incompatibilityWarning);
+      });
+      it('does not warn when proxy disabled', () => {
+        createAurora({ ...defaultAuroraProps, skipProxy: true });
+        annotations.hasNoWarning('*', incompatibilityWarning);
+      });
+    });
+
     it('activityStream', () => {
       const postgresEngineVersion = AuroraPostgresEngineVersion.VER_11_16;
       createAurora({ ...defaultAuroraProps, activityStream: true, postgresEngineVersion });