-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the cursor position #89
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A bug to solve for the future maintainer :)
The position of the cursor is kind of wrong calculated.
bbb-video-download/src/modules/slides.js
Lines 229 to 232 in 93b894c
It should be more like this:
https://github.com/bigbluebutton/bbb-playback/blob/ba7e67d8c352d6a5383cc42442178a880db10da7/src/components/presentation/cursor.js#L18-L19
At least bbb and my bbb-dl uses this calculation, and they look correct.
I also want to point out, that bbb finally published there own script to render the presentation video (without deskshare/webcams) https://github.com/bigbluebutton/bbb-presentation-video. Maybe this can be useful for the future maintainer :D
The text was updated successfully, but these errors were encountered: