-
Notifications
You must be signed in to change notification settings - Fork 419
[Refactor] Enhance T.alloc_barrier with new features and deprecate legacy mbarrier related intrinsics
#1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rachmanino
wants to merge
15
commits into
tile-ai:main
Choose a base branch
from
Rachmanino:mbar-rft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6c0f6e7
enhance `T.alloc_barrier` and let `T.wait/arrive` only accept buffers
Rachmanino d1fffa5
lint
Rachmanino 446b5dc
Refactor mbarrier handling and update related documentation
Rachmanino 2871eb4
lint
Rachmanino bceda19
fix test
Rachmanino e14cc29
tcgen5 check input
Rachmanino bc9d192
lint
Rachmanino 551f7b8
fix name conflict
Rachmanino e4bd948
add name check
Rachmanino 3e5254c
apply ai suggestions
Rachmanino 8bb51e5
fix shared mem disalignment and missing fence for mbarrier init
Rachmanino 7308bce
fix cutedsl codegen
Rachmanino 6591a54
bugfix
Rachmanino a0ceb32
add test for cutedsl codegen
Rachmanino 3cf3e49
Update testing/python/jit/test_tilelang_jit_cutedsl.py
Rachmanino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #ifndef TVM_TL_TRANSFORM_COMMON_MBARRIER_H_ | ||
| #define TVM_TL_TRANSFORM_COMMON_MBARRIER_H_ | ||
|
|
||
| #include "../../op/builtin.h" | ||
| #include <tvm/ir/expr.h> | ||
| #include <tvm/tir/builtin.h> | ||
| #include <tvm/tir/expr.h> | ||
| #include <tvm/tir/op.h> | ||
| #include <tvm/tir/stmt.h> | ||
|
|
||
| namespace tvm { | ||
| namespace tl { | ||
|
|
||
| using namespace tir; | ||
|
|
||
| /*! | ||
| * \brief Create an mbarrier buffer with shared.barrier storage scope. | ||
| * | ||
| * \param name The name of the buffer. | ||
| * \param num_barriers The number of barriers in the buffer. | ||
| * \return A Buffer object for mbarrier with shared.barrier scope. | ||
| */ | ||
| inline Buffer CreateMBarrierBuffer(const std::string &name, int num_barriers) { | ||
| Var data(name, PointerType(PrimType(DataType::UInt(64)), "shared.barrier")); | ||
| return Buffer(data, DataType::UInt(64), | ||
| {IntImm(DataType::Int(32), num_barriers)}, {}, PrimExpr(), name, | ||
| 0, 0, kDefault); | ||
| } | ||
|
|
||
| const std::string injected_mbarrier_name_ = | ||
| "mbarrier"; // todo: avoid conflict with user-defined mbarriers | ||
|
|
||
| } // namespace tl | ||
| } // namespace tvm | ||
| #endif // TVM_TL_TRANSFORM_COMMON_MBARRIER_H_ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz review this, since im not very familiar with cutedsl details though ci passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to have a simple mbarrier codegen test for this modification.