A status don't check and are written by later code in BlobGCJob::InstallOutputBlobFiles

[apple-ouyang]

In BlobGCJob::InstallOutputBlobFiles, which is blob_gc_joob.cc:415, the status are not checked.

for (auto& builder : blob_file_builders_) {
    BlobFileBuilder::OutContexts contexts;
    s = builder.second->Finish(&contexts);  // Status not check
    BatchWriteNewIndices(contexts, &s);     // Status is written
    if (!s.ok()) {
      break;
    }
    metrics_.gc_num_new_files++;

At the same time, I think the BatchWriteNewIndices(contexts, &s) can be rewritten like s = BatchWriteNewIndices(contexts)
This will ensure code consistency as every funciton return a stauts.

I can make a PR to fix thoese 2 things If you like.

[Connor1996]

Yes, better rewrite it.

[apple-ouyang]

I push a PR here #243