Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disable_proposal_forwarding config params #552

Merged
merged 4 commits into from
Oct 21, 2024
Merged

feat: add disable_proposal_forwarding config params #552

merged 4 commits into from
Oct 21, 2024

Conversation

datbeohbbh
Copy link
Contributor

resolve #550

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

Welcome @datbeohbbh! It looks like this is your first PR to tikv/raft-rs 🎉

@datbeohbbh datbeohbbh force-pushed the feat/add-disable-proposal-forwarding branch from ddb3255 to bced3c2 Compare October 8, 2024 17:02
BusyJay
BusyJay reviewed Oct 9, 2024
View reviewed changes
src/raft.rs Outdated Show resolved Hide resolved
harness/tests/integration_cases/test_raft.rs Outdated Show resolved Hide resolved
@datbeohbbh datbeohbbh requested a review from BusyJay October 9, 2024 04:44
@datbeohbbh
Copy link
Contributor Author

@BusyJay can you please check CI clippy? It's seem that clippy throw error on other code parts which are not relevant to this PR.

@BusyJay
Copy link
Member

BusyJay commented Oct 9, 2024

If you are interested, you can fix them in this PR (or a new PR).

@datbeohbbh
Copy link
Contributor Author

If you are interested, you can fix them in this PR (or a new PR).

I will fix in my next PR. This PR should be about this feature :D

@BusyJay
Copy link
Member

BusyJay commented Oct 11, 2024

If you are interested, you can fix them in this PR (or a new PR).

I will fix in my next PR. This PR should be about this feature :D

OK, let's hold this one for now till CI is working again.

@datbeohbbh datbeohbbh mentioned this pull request Oct 14, 2024
Merged
@datbeohbbh datbeohbbh force-pushed the feat/add-disable-proposal-forwarding branch from 9d3aa0d to 22677bf Compare October 20, 2024 08:16
@datbeohbbh
fix: fix assert empty msgs
ac4b281 
Signed-off-by: Dat Tien Nguyen <[email protected]>
@datbeohbbh
Copy link
Contributor Author

datbeohbbh commented Oct 21, 2024 •
edited
Loading

If you are interested, you can fix them in this PR (or a new PR).

I will fix in my next PR. This PR should be about this feature :D

OK, let's hold this one for now till CI is working again.

@BusyJay CI worked, I have rebased this PR onto master.

@BusyJay BusyJay merged commit 63aec46 into tikv:master Oct 21, 2024
6 checks passed
@BusyJay
Copy link
Member

BusyJay commented Oct 21, 2024

Well done! Thank you!

@datbeohbbh datbeohbbh deleted the feat/add-disable-proposal-forwarding branch October 21, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BusyJay BusyJay BusyJay approved these changes

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: add raft config parameters disable_proposal_forwarding
2 participants
@datbeohbbh @BusyJay