Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchPut panics when keys are spread across regions #458

Closed
limbooverlambda opened this issue Jun 17, 2024 · 1 comment
Closed

BatchPut panics when keys are spread across regions #458

limbooverlambda opened this issue Jun 17, 2024 · 1 comment

Comments

@limbooverlambda
Copy link
Contributor

There is a bug in the client where the ttls are not properly sharded for RawBatchPuts. This essentially means that if the batch is spread across multiple regions, the ttls for the batch specific to the shard is not properly aligned. This is an issue when the request ends up in the TiKV node specific to the region and fails because of the misalignment of the Vec with its corresponding Vec. This results in TiKV panicking with "The length of ttls does not equal to the length of pairs". The fix was to change the sharding logic for RawBatchPutRequest so that the TTLs are aligned with the KvPair.

Here's the PR with the fix: #457

@pingyu @andylokandy @ekexium

@limbooverlambda
Copy link
Contributor Author

Fixed as part of #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant