pd: handle get members with error (#452) (#496)

Signed-off-by: Ping Yu <[email protected]>

Author: pingyu

src/common/errors.rs

@@ -111,6 +111,8 @@ pub enum Error {
     },
     #[error("Transaction not found error: {:?}", _0)]
     TxnNotFound(kvrpcpb::TxnNotFound),
+    #[error("PD has no leader")]
+    PdNoLeader,
 }
 
 impl From<crate::proto::errorpb::Error> for Error {

src/pd/cluster.rs

@@ -16,6 +16,7 @@ use tonic::Request;
 use super::timestamp::TimestampOracle;
 use crate::internal_err;
 use crate::proto::pdpb;
+use crate::Error;
 use crate::Result;
 use crate::SecurityManager;
 use crate::Timestamp;
@@ -46,7 +47,7 @@ impl Cluster {
         timeout: Duration,
     ) -> Result<pdpb::GetRegionResponse> {
         let mut req = pd_request!(self.id, pdpb::GetRegionRequest);
-        req.region_key = key.clone();
+        req.region_key = key;
         req.send(&mut self.client, timeout).await
     }
 
@@ -203,6 +204,16 @@ impl Connection {
             .get_members(pdpb::GetMembersRequest::default())
             .await?
             .into_inner();
+        if let Some(err) = resp
+            .header
+            .as_ref()
+            .and_then(|header| header.error.as_ref())
+        {
+            return Err(internal_err!("failed to get PD members, err {:?}", err));
+        }
+        if resp.leader.is_none() {
+            return Err(Error::PdNoLeader);
+        }
         Ok((client, resp))
     }